Page MenuHomePhabricator

Fix an RRULE issue with month days at the end of the month
ClosedPublic

Authored by epriestley on Sep 27 2016, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 15 2024, 6:59 PM
Unknown Object (File)
Oct 14 2024, 5:01 AM
Unknown Object (File)
Sep 30 2024, 5:48 PM
Unknown Object (File)
Sep 24 2024, 10:41 AM
Unknown Object (File)
Sep 20 2024, 10:05 AM
Unknown Object (File)
Sep 20 2024, 3:18 AM
Unknown Object (File)
Sep 12 2024, 10:53 AM
Unknown Object (File)
Sep 12 2024, 10:52 AM
Subscribers
None

Details

Summary

Ref T10747. I'm porting unit tests from other implementations until I hit one that fails.

The "yearly event on Feb 29th" test failed because we assumed every month had a 29th. Instead, test if the current month has a 29th.

We were also using cursorX instead of stateX in a couple places. They often have the same value, but stateX is the correct value when they differ.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an RRULE issue with month days at the end of the month.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 27 2016, 10:37 PM
This revision was automatically updated to reflect the committed changes.