Page MenuHomePhabricator
Differential D16661

Store "start", "end", and "until" event dates as CalendarDateTime objects
ClosedPublic
Actions

Authored by epriestley on Oct 4 2016, 4:25 PM.
Tags
None
Referenced Files
F14057574: D16661.diff
Sun, Nov 17, 4:44 AM
F14057350: D16661.diff
Sun, Nov 17, 2:22 AM
F14046618: D16661.id40113.diff
Wed, Nov 13, 10:28 PM
F14010870: D16661.diff
Thu, Oct 31, 1:04 PM
F13995926: D16661.id40145.diff
Wed, Oct 23, 4:46 PM
F13978084: D16661.diff
Oct 18 2024, 9:28 PM
F13974254: D16661.id.diff
Oct 18 2024, 4:44 AM
F13961862: D16661.id.diff
Oct 15 2024, 6:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPe042533375d3: Store "start", "end", and "until" event dates as CalendarDateTime objects
Summary

Ref T10747. This does double-writes and starts generating/writing CalendarDateTimes.

This greater flexibility is necessary to support the full range of ICS-specifiable events, including "floating" events.

This doesn't do anything yet.

Test Plan

Created and edited events, verified sensible representations of corresponding datetimes appeared in the database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40113.Oct 4 2016, 4:25 PM
epriestley retitled this revision from to Store "start", "end", and "until" event dates as CalendarDateTime objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 4 2016, 4:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 4:49 PM
Closed by commit rPe042533375d3: Store "start", "end", and "until" event dates as CalendarDateTime objects (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40145

View Options

resources/sql/autopatches/20161003.cal.02.parameters.sql

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventAllDayTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php

Loading...
Phabricator · Built by Phacility