Page MenuHomePhabricator

Fix an RRULE bug with day cursors and skipped months
ClosedPublic

Authored by epriestley on Sep 28 2016, 2:32 PM.
Tags
None
Referenced Files
F13979150: D16619.diff
Sat, Oct 19, 2:54 AM
F13967722: D16619.id40021.diff
Wed, Oct 16, 3:32 PM
F13961035: D16619.id.diff
Tue, Oct 15, 2:45 AM
Unknown Object (File)
Oct 4 2024, 11:40 PM
Unknown Object (File)
Sep 30 2024, 10:52 PM
Unknown Object (File)
Sep 24 2024, 10:35 PM
Unknown Object (File)
Sep 15 2024, 7:05 PM
Unknown Object (File)
Sep 12 2024, 11:18 AM
Subscribers
None

Details

Summary

Ref T10747. This rule wasn't quite correct, and got some things like BYMONTH=1,3;INTERVAL=9 wrong.

Instead of resetting the day cursor to 1, we need to move it forward through time in INTERVAL jumps until we get to the next candidate month.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an RRULE bug with day cursors and skipped months.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 6:24 PM
This revision was automatically updated to reflect the committed changes.