Differential D16614

Implement RRULE support for BYDAY with relative offsets ("FREQ=YEARLY;BYDAY=-19TU")
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 12:48 AM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU90b5670cd5e0: Implement RRULE support for BYDAY with relative offsets ("FREQ=YEARLY;BYDAY=…

Summary

Ref T10747. Finally, we can schedule an event on the -19th Thursday of the year.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39987.Sep 28 2016, 12:48 AM

epriestley retitled this revision from to Implement RRULE support for BYDAY with relative offsets ("FREQ=YEARLY;BYDAY=-19TU").

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 1:35 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 1:35 AM

Closed by commit rPHU90b5670cd5e0: Implement RRULE support for BYDAY with relative offsets ("FREQ=YEARLY;BYDAY=… (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

73 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

48 lines

Diff 40004

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Implement RRULE support for BYDAY with relative offsets ("FREQ=YEARLY;BYDAY=-19TU")ClosedPublicActions