Differential D16729

Fix some minor parsing bugs in ICS parser
ClosedPublic
Actions

Authored by epriestley on Oct 19 2016, 4:55 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU20841d232127: (stable) Promote 2016 Week 43
rPHUf275bb3a363d: Fix some minor parsing bugs in ICS parser

Summary

Ref T10747. Cleans up some integer/property handling a touch.

Test Plan

Imported more complex ICS events.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40282.Oct 19 2016, 4:55 PM

epriestley retitled this revision from to Fix some minor parsing bugs in ICS parser.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 19 2016, 5:48 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 19 2016, 5:48 PM

Closed by commit rPHUf275bb3a363d: Fix some minor parsing bugs in ICS parser (authored by epriestley, committed by epriestley). · Explain WhyOct 19 2016, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

32 lines

ics/

PhutilICSParser.php

4 lines

Diff 40287

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php