Page MenuHomePhabricator

Make .ics export less scary and attach .ics files to event mail
ClosedPublic

Authored by epriestley on Sep 15 2016, 2:01 PM.
Tags
None
Referenced Files
F13062594: D16559.diff
Sat, Apr 20, 1:09 AM
F13060090: D16559.diff
Fri, Apr 19, 5:18 PM
Unknown Object (File)
Mon, Apr 15, 1:26 PM
Unknown Object (File)
Sat, Mar 30, 11:14 AM
Unknown Object (File)
Sat, Mar 30, 8:47 AM
Unknown Object (File)
Sat, Mar 30, 8:47 AM
Unknown Object (File)
Sat, Mar 30, 8:47 AM
Unknown Object (File)
Mar 21 2024, 10:54 AM
Subscribers
None

Details

Summary

Ref T10747.

  • Remove the warning dialog since these files don't seem to do anything confusing/problematic in Calendar.app or Google Calendar. Those importers generally need to be defensive about how they handle random ".ics" files from arbitrary third parties anyway, and this makes testing imports easier since we have a GET-table ".ics" URI for public events.
  • Attach ".ics" files to email.
Test Plan
  • Clicked "Export as .ics", got an ICS file.
  • Used "bin/mail show-outbound" to review an ICS attachment, although I don't actually have real mail set up locally so this may still be a little funky.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make .ics export less scary and attach .ics files to event mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2016, 2:40 PM
This revision was automatically updated to reflect the committed changes.