Page MenuHomePhabricator
Differential D16767

Fix an issue importing instantaneous events
ClosedPublic
Actions

Authored by epriestley on Oct 28 2016, 10:44 PM.
Tags
None
Referenced Files
F18777795: D16767.id.diff
Sat, Oct 11, 5:31 AM
F18765492: D16767.diff
Tue, Oct 7, 11:35 AM
F18755707: D16767.diff
Sun, Oct 5, 7:00 AM
F18748483: D16767.diff
Fri, Oct 3, 10:48 PM
F18735414: D16767.id40381.diff
Wed, Oct 1, 1:15 AM
F18702433: D16767.diff
Sun, Sep 28, 12:04 AM
F18637383: D16767.id40380.diff
Wed, Sep 17, 7:19 AM
F18508229: D16767.id.diff
Sep 5 2025, 2:41 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHUf62a265bad60: Fix an issue importing instantaneous events
Summary

Ref T10747. It's possible to define instantaneous events (no end date or duration) but we currently fail when trying to import them.

Test Plan

Imported an instantaneous event.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40380.Oct 28 2016, 10:44 PM
epriestley retitled this revision from to Fix an issue importing instantaneous events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 28 2016, 10:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2016, 10:45 PM
Closed by commit rPHUf62a265bad60: Fix an issue importing instantaneous events (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2016, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
3 lines

Diff 40381

View Options

src/parser/calendar/data/PhutilCalendarEventNode.php

Loading...
Phabricator · Built by Phacility