Page MenuHomePhabricator
Differential D16670

Convert Calendar Events to use RRULE frequency constants in various other places
ClosedPublic
Actions

Authored by epriestley on Oct 5 2016, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 4:42 AM
Unknown Object (File)
Thu, Jan 30, 1:11 PM
Unknown Object (File)
Wed, Jan 29, 9:13 AM
Unknown Object (File)
Mon, Jan 27, 4:58 AM
Unknown Object (File)
Sat, Jan 25, 2:11 PM
Unknown Object (File)
Sat, Jan 25, 2:11 PM
Unknown Object (File)
Sat, Jan 25, 2:11 PM
Unknown Object (File)
Thu, Jan 23, 8:36 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rP3164ff68db58: Convert Calendar Events to use RRULE frequency constants in various other places
Summary

Ref T10747.

  • Store recurrence as RRULEs internally.
  • Use RRULE constants.
  • Migrate existing rules to RRULEs.
Test Plan

Ran migration, nothing seemed broken?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40128.Oct 5 2016, 6:26 PM
epriestley retitled this revision from to Convert Calendar Events to use RRULE frequency constants in various other places.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 5 2016, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2016, 8:25 PM
Closed by commit rP3164ff68db58: Convert Calendar Events to use RRULE frequency constants in various other places (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 11:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
44 lines
src/
applications/
calendar/
controller/
19 lines
editor/
18 lines
storage/
59 lines
xaction/
74 lines

Diff 40151

View Options

resources/sql/autopatches/20161005.cal.01.rrules.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

Loading...
Phabricator · Built by Phacility