Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:09 AM
Unknown Object (File)
Sat, Mar 30, 11:14 AM
Unknown Object (File)
Feb 11 2024, 7:42 PM
Unknown Object (File)
Feb 3 2024, 12:31 PM
Unknown Object (File)
Feb 2 2024, 5:39 PM
Unknown Object (File)
Jan 24 2024, 11:37 AM
Unknown Object (File)
Jan 16 2024, 9:10 AM
Unknown Object (File)
Jan 14 2024, 2:11 PM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.