Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
F19945915: D16716.diff
Thu, Apr 16, 9:19 PM
F19942933: D16716.diff
Wed, Apr 15, 11:41 PM
F19931331: D16716.diff
Thu, Apr 9, 5:17 PM
F19843966: D16716.id40258.diff
Mar 12 2026, 3:58 AM
F19826714: D16716.diff
Mar 9 2026, 12:33 AM
F19801385: D16716.id40262.diff
Feb 28 2026, 11:20 PM
F19801378: D16716.id40258.diff
Feb 28 2026, 11:19 PM
F19800970: D16716.id40262.diff
Feb 28 2026, 7:44 PM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.