Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
F13991175: D16716.id.diff
Tue, Oct 22, 9:07 AM
F13976290: D16716.diff
Oct 18 2024, 1:38 PM
F13967120: D16716.id40258.diff
Oct 16 2024, 11:50 AM
Unknown Object (File)
Oct 9 2024, 5:30 AM
Unknown Object (File)
Sep 30 2024, 8:05 PM
Unknown Object (File)
Sep 25 2024, 2:05 AM
Unknown Object (File)
Sep 4 2024, 11:01 PM
Unknown Object (File)
Sep 4 2024, 4:59 PM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.