Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 7:00 AM
Unknown Object (File)
Sun, Jan 26, 5:40 AM
Unknown Object (File)
Sat, Jan 25, 2:14 PM
Unknown Object (File)
Sat, Jan 25, 2:14 PM
Unknown Object (File)
Sat, Jan 25, 2:14 PM
Unknown Object (File)
Sat, Jan 25, 5:32 AM
Unknown Object (File)
Fri, Jan 24, 12:12 PM
Unknown Object (File)
Thu, Jan 23, 8:38 PM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.