Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
F15580000: D16716.id40258.diff
Wed, May 7, 2:51 AM
F15568278: D16716.id40258.diff
Fri, May 2, 11:33 PM
F15550881: D16716.id40262.diff
Sun, Apr 27, 2:17 PM
F15542800: D16716.id40258.diff
Fri, Apr 25, 6:59 PM
F15541966: D16716.id.diff
Fri, Apr 25, 2:44 PM
F15536885: D16716.diff
Thu, Apr 24, 11:12 AM
F15527109: D16716.diff
Tue, Apr 22, 12:45 AM
F15510093: D16716.id.diff
Wed, Apr 16, 6:39 PM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.