Page MenuHomePhabricator
Differential D16631

Add SECONDLY tests to RRULE code
ClosedPublic
Actions

Authored by epriestley on Sep 29 2016, 7:12 PM.
Tags
None
Referenced Files
F14025015: D16631.diff
Thu, Nov 7, 1:58 PM
F13999785: D16631.diff
Thu, Oct 24, 5:12 PM
F13990423: D16631.diff
Tue, Oct 22, 3:34 AM
F13989881: D16631.id40038.diff
Mon, Oct 21, 11:40 PM
F13985829: D16631.id.diff
Sun, Oct 20, 11:05 PM
F13975317: D16631.id40038.diff
Fri, Oct 18, 9:38 AM
F13975271: D16631.id40038.diff
Fri, Oct 18, 9:29 AM
F13963252: D16631.id40050.diff
Tue, Oct 15, 2:51 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHUb077cfaf1b07: Add SECONDLY tests to RRULE code
Summary

Ref T10747. These pretty much worked. BYSETPOS does not make sense with SECONDLY, as far as I can tell.

Test Plan

Unit tests pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40038.Sep 29 2016, 7:12 PM
epriestley retitled this revision from to Add SECONDLY tests to RRULE code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Sep 29 2016, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 8:25 PM
Closed by commit rPHUb077cfaf1b07: Add SECONDLY tests to RRULE code (authored by epriestley, committed by epriestley). · Explain WhySep 29 2016, 11:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
3 lines
__tests__/
49 lines

Diff 40050

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Loading...
View Options

src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php

Loading...
Phabricator · Built by Phacility