Page MenuHomePhabricator

When import fails because we can't parse an ICS file, show it nicely
ClosedPublic

Authored by epriestley on Oct 18 2016, 8:54 PM.
Tags
None
Referenced Files
F14054371: D16721.diff
Sat, Nov 16, 12:50 AM
F14041519: D16721.diff
Mon, Nov 11, 7:21 PM
F14026278: D16721.diff
Fri, Nov 8, 12:49 AM
F14006315: D16721.diff
Mon, Oct 28, 6:12 AM
F13992453: D16721.id40272.diff
Tue, Oct 22, 4:46 PM
F13992048: D16721.id.diff
Tue, Oct 22, 2:06 PM
F13978513: D16721.id40267.diff
Oct 18 2024, 11:33 PM
Unknown Object (File)
Oct 9 2024, 5:35 AM
Subscribers
None

Details

Summary

Ref T10747. When we hit an ICS parser error, render it into a log instead of fataling.

(This will be more important in the future with subscription-based URL ICS import.)

Test Plan

Screen Shot 2016-10-18 at 1.49.43 PM.png (904×1 px, 133 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When import fails because we can't parse an ICS file, show it nicely.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.