Page MenuHomePhabricator

When import fails because we can't parse an ICS file, show it nicely
ClosedPublic

Authored by epriestley on Oct 18 2016, 8:54 PM.
Tags
None
Referenced Files
F18849985: D16721.id.diff
Thu, Oct 30, 1:38 PM
F18845528: D16721.diff
Wed, Oct 29, 12:46 PM
F18843976: D16721.id40267.diff
Wed, Oct 29, 2:20 AM
F18804180: D16721.id40267.diff
Sat, Oct 18, 6:39 AM
F18803804: D16721.id40272.diff
Sat, Oct 18, 4:07 AM
F18798272: D16721.diff
Fri, Oct 17, 6:11 AM
F18722204: D16721.id40267.diff
Sep 29 2025, 10:22 PM
F18632358: D16721.id.diff
Sep 16 2025, 5:51 PM
Subscribers
None

Details

Summary

Ref T10747. When we hit an ICS parser error, render it into a log instead of fataling.

(This will be more important in the future with subscription-based URL ICS import.)

Test Plan

Screen Shot 2016-10-18 at 1.49.43 PM.png (904×1 px, 133 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When import fails because we can't parse an ICS file, show it nicely.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.