Page MenuHomePhabricator
Differential D16770

Properly import all-day events in Calendar
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 3:14 PM.
Tags
None
Referenced Files
F17935248: D16770.id.diff
Wed, Jul 30, 11:15 PM
F17683542: D16770.diff
Mon, Jul 14, 12:39 AM
Unknown Object (File)
Jun 16 2025, 8:29 AM
Unknown Object (File)
Jun 16 2025, 8:04 AM
Unknown Object (File)
Jun 15 2025, 8:32 PM
Unknown Object (File)
Jun 15 2025, 11:25 AM
Unknown Object (File)
May 29 2025, 8:43 AM
Unknown Object (File)
May 18 2025, 8:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rP96b064b7e9b2: Properly import all-day events in Calendar
Summary

Ref T10747. The transaction version of this copies the "all day" flag over properly, but this non-transaction version needs to copy it explicitly.

Test Plan

Imported an all-day event, saw it come in as all-day.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40392.Oct 30 2016, 3:14 PM
epriestley retitled this revision from to Properly import all-day events in Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 30 2016, 3:15 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2016, 3:15 PM
Closed by commit rP96b064b7e9b2: Properly import all-day events in Calendar (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
import/
2 lines

Diff 40396

View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Loading...
Phabricator · Built by Phacility