Properly import all-day events in Calendar
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 3:14 PM.

Tags

None

Referenced Files

	F15582617: D16770.id40392.diff
	Wed, May 7, 5:13 PM

	F15549678: D16770.id40396.diff
	Sun, Apr 27, 7:15 AM

	F15547644: D16770.id40392.diff
	Sat, Apr 26, 7:55 PM

	F15544373: D16770.id40392.diff
	Sat, Apr 26, 4:32 AM

	F15541671: D16770.id.diff
	Fri, Apr 25, 12:57 PM

	F15539011: D16770.diff
	Thu, Apr 24, 10:48 PM

	F15523631: D16770.diff
	Mon, Apr 21, 2:38 AM

	F15439467: D16770.id40396.diff
	Mar 26 2025, 7:41 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rP96b064b7e9b2: Properly import all-day events in Calendar

Summary

Ref T10747. The transaction version of this copies the "all day" flag over properly, but this non-transaction version needs to copy it explicitly.

Test Plan

Imported an all-day event, saw it come in as all-day.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40392.Oct 30 2016, 3:14 PM

epriestley retitled this revision from to Properly import all-day events in Calendar.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 30 2016, 3:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 3:15 PM

Closed by commit rP96b064b7e9b2: Properly import all-day events in Calendar (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 4:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

import/

PhabricatorCalendarImportEngine.php

2 lines

Diff 40396

View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Properly import all-day events in CalendarClosedPublicActions