Page MenuHomePhabricator
Differential D16748

Fix import casts for RRULE "INTERVAL" and "COUNT" properties
ClosedPublic
Actions

Authored by epriestley on Oct 25 2016, 5:18 PM.
Tags
None
Referenced Files
F15383513: D16748.id40338.diff
Fri, Mar 14, 4:58 PM
F15377182: D16748.id.diff
Thu, Mar 13, 8:20 AM
F15328683: D16748.id40338.diff
Fri, Mar 7, 5:56 AM
Unknown Object (File)
Sat, Mar 1, 7:52 PM
Unknown Object (File)
Mon, Feb 24, 1:12 PM
Unknown Object (File)
Wed, Feb 19, 12:32 AM
Unknown Object (File)
Tue, Feb 18, 6:13 PM
Unknown Object (File)
Tue, Feb 18, 11:56 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHU6d6308803540: Fix import casts for RRULE "INTERVAL" and "COUNT" properties
Summary

Ref T10747. When present, these should both be integers.

Test Plan

Imported an event repeating 5 times, every other day.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40334.Oct 25 2016, 5:18 PM
epriestley retitled this revision from to Fix import casts for RRULE "INTERVAL" and "COUNT" properties.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 25 2016, 5:33 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 25 2016, 5:33 PM
Closed by commit rPHU6d6308803540: Fix import casts for RRULE "INTERVAL" and "COUNT" properties (authored by epriestley, committed by epriestley). · Explain WhyOct 25 2016, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
19 lines

Diff 40338

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Loading...
Phabricator · Built by Phacility