Page MenuHomePhabricator

Give organizers in ICS exports a dummy email address to placate Gmail
ClosedPublic

Authored by epriestley on Oct 30 2016, 4:13 PM.

Details

Summary

Ref T10747. In the in-email ICS event card that Gmail shows, it has a "Who" field which reads "Unknown Organizer*" if the URI for the organizer isn't email-address-like.

Previously, we used a URI like https://phabricator.install.com/p/username, which I think is OK as far as RFC 5545 is concerned, but Gmail doesn't like it.

Instead, use PHID-USER-asdfa@phabricator.install.com, which doesn't go anywhere, but makes Gmail happy. Users don't normally see this URI anyway.

Test Plan

Got a readable "Who" in Gmail when importing an event exported from Calendar:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 40394.Oct 30 2016, 4:13 PM
epriestley retitled this revision from to Give organizers in ICS exports a dummy email address to placate Gmail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 30 2016, 4:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2016, 4:18 PM
This revision was automatically updated to reflect the committed changes.