Paths

Table of Contentst

Differential D16772

Give organizers in ICS exports a dummy email address to placate Gmail
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 4:13 PM.

Tags

None

Referenced Files

	F13060231: D16772.diff
	Fri, Apr 19, 5:32 PM

	Unknown Object (File)
	Sat, Apr 13, 4:58 PM

	Unknown Object (File)
	Thu, Apr 11, 8:18 AM

	Unknown Object (File)
	Sat, Apr 6, 12:35 AM

	Unknown Object (File)
	Thu, Apr 4, 8:56 AM

	Unknown Object (File)
	Fri, Mar 29, 11:50 PM

	Unknown Object (File)
	Thu, Mar 28, 5:30 AM

	Unknown Object (File)
	Thu, Mar 21, 11:38 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPe1a9b7694517: Give organizers in ICS exports a dummy email address to placate Gmail

Summary

Ref T10747. In the in-email ICS event card that Gmail shows, it has a "Who" field which reads "Unknown Organizer*" if the URI for the organizer isn't email-address-like.

Previously, we used a URI like https://phabricator.install.com/p/username, which I think is OK as far as RFC 5545 is concerned, but Gmail doesn't like it.

Instead, use PHID-USER-asdfa@phabricator.install.com, which doesn't go anywhere, but makes Gmail happy. Users don't normally see this URI anyway.

Test Plan

Got a readable "Who" in Gmail when importing an event exported from Calendar:

Screen Shot 2016-10-30 at 9.12.16 AM.png (272×525 px, 25 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40394.Oct 30 2016, 4:13 PM

epriestley retitled this revision from to Give organizers in ICS exports a dummy email address to placate Gmail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 30 2016, 4:18 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 4:18 PM

Closed by commit rPe1a9b7694517: Give organizers in ICS exports a dummy email address to placate Gmail (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

14 lines

Diff 40398

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...