Page MenuHomePhabricator

Use transactions when importing events in Calendar, and update existing events
ClosedPublic

Authored by epriestley on Oct 13 2016, 3:04 PM.
Tags
None
Referenced Files
F14063138: D16701.diff
Mon, Nov 18, 4:48 PM
F14050451: D16701.id40204.diff
Thu, Nov 14, 6:47 PM
F14049333: D16701.diff
Thu, Nov 14, 12:39 PM
F14001180: D16701.diff
Fri, Oct 25, 4:53 AM
F13994916: D16701.id40208.diff
Wed, Oct 23, 9:25 AM
F13959335: D16701.diff
Oct 14 2024, 6:55 PM
Unknown Object (File)
Oct 9 2024, 5:16 AM
Unknown Object (File)
Oct 7 2024, 9:54 PM
Subscribers
None

Details

Summary

Ref T10747.

  • Apply what changes we can with transactions, so you can see how an event has changed and import actions are more explicit.
    • I'll hide these from email/feed soon: I want them to appear on the event, but not generate notifications, since that could be especially annoying for automated events.
  • When importing, try to update existing events if we can.
Test Plan

Imported a ".ics" file several times with minor changes, saw them reflected in the UI with transactions.

Screen Shot 2016-10-13 at 8.00.54 AM.png (502×755 px, 71 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use transactions when importing events in Calendar, and update existing events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 3:52 PM
This revision was automatically updated to reflect the committed changes.