HomePhabricator

Make error handling for ICS parsing more robust

Description

Make error handling for ICS parsing more robust

Summary:
Ref T10747. This mostly adds a bunch of test cases for the ICS format syntax errors, and fixes a couple of issues:

  • Multiple VCALENDAR sections in one .ics file is legal according to the spec.
  • Had some bugs with parsing properties with multiple parameters.
  • Tighten up the regexp for property names.
  • Show a lot more detail about what went wrong when parsing fails.

Test Plan: Ran unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16521

Details

Provenance
epriestleyAuthored on Sep 8 2016, 9:41 PM
epriestleyPushed on Sep 12 2016, 2:23 PM
Reviewer
chad
Differential Revision
D16521: Make error handling for ICS parsing more robust
Parents
rPHU0107c187b6d8: Add a very basic ICS syntax parser
Branches
Unknown
Tags
Unknown
Tasks
T10747: Import and export ICS from Calendar
Build Status
Buildable 13685
Build 17651: Run Core Tests