Page MenuHomePhabricator

Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES
ClosedPublic

Authored by epriestley on Sep 28 2016, 12:17 AM.
Tags
None
Referenced Files
F15541881: D16612.id.diff
Fri, Apr 25, 2:06 PM
F15541179: D16612.id40002.diff
Fri, Apr 25, 11:17 AM
F15537766: D16612.diff
Thu, Apr 24, 3:36 PM
F15478298: D16612.id40002.diff
Mon, Apr 7, 9:51 PM
F15478297: D16612.id40002.diff
Mon, Apr 7, 9:50 PM
F15460852: D16612.id39985.diff
Tue, Apr 1, 2:54 AM
F15384312: D16612.id39985.diff
Mar 14 2025, 7:28 PM
F15297780: D16612.id40002.diff
Mar 5 2025, 12:36 PM
Subscribers
None

Details

Summary

Ref T10747. If you have an all-day event, we normally return all-day events.

If the frequency is HOURLY or higher though, or the set has been expanded by a rule like BYHOUR, we need to iterate hours/minutes/seconds and return date-time results.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 12:40 AM
This revision was automatically updated to reflect the committed changes.