- User Since
- Nov 28 2011, 9:35 AM (268 w, 5 d)
Wed, Jan 18
Dec 5 2016
Dec 4 2016
Dec 2 2016
Dec 1 2016
Nov 23 2016
This all seems reasonable, I'm actually not 100% sure what happened so I'll try to gather a better understanding of the situation ;)
Nov 22 2016
Nov 18 2016
Nov 17 2016
Nov 15 2016
Fixed in config
Nov 14 2016
FWIW: I believe @paladox means well, he's just young/inexperienced and overly enthusiastic. The decision to ban him is entirely reasonable for upstream though, given the circumstances.
Nov 10 2016
Oct 13 2016
Somehow this didn't autoclose.
Oct 12 2016
Would it be safe for me to write a migration that sets utcInstanceEpoch equal to utcInitialEpoch on every row in the calendar_event table?
After running the migrations, some instances of recurring events end up with null for the utcInstanceEpoch column. I'm not sure how this happened, however, as some of the instances have a value that matches utcInitialEpoch and I'm not entirely sure what the purpose of utcInstanceEpoch would be. If it matches InitialEpoch then it seems kinda useless, as does null...
@epriestley: Sounds good to me, this seems quite sensible in every way.
@epriestley: Jaime, Senior DBA at the WMF, has posted some answers for your list of questions:
Oct 9 2016
Also, reindexing is required after switching to innodb.
Does InnoDB FULLTEXT respect ft_boolean_syntax? If no: is there another similar option? If no: we need to parse queries ourselves and submit the +A +B version to the backend (see also T10642).
That's some pretty awesome support for an unsupported prototype. Kudos!
Oct 5 2016
Oct 2 2016
@vanmeeuwen couldn't you use custom forms to lock/hide the policy controls on the maniphest task submission / edit forms? That's how we handled it at Wikimedia's Phabricator. As mentioned above, Custom Forms is the general way forward for controlling default task policies.
Sep 29 2016
I doubt that upstream is interested in adding yet another configuration option, however, in case anyone runs across this issue, the following patch will make phabricator work with newer elasticsearch versions (2+)
So far innodb is working. I can't say if it's worse than myisam really, seems pretty similar. Stemming would help a lot but the main complaint I have is the ranking algorithm seems really bad. It doesn't return the most relevant results first. myisam had the same problem though.
Sep 28 2016
With InnoDB now mostly finished indexing, search seems to be working and the service isn't getting killed by locked tables. More info at the link I pasted above ^
Wikimedia is considering another stab at elasticsearch because we just hit a fairly serious scalability issue with myisam (https://phabricator.wikimedia.org/T146673) and it looks like innodb isn't a lot better. In addition to that, the mysql fulltext engines don't seem to handle stemming or even simple prefix matching.
+1 for mentions, that would serve the same purpose as see also: or related tasks: would. Primarily it would just be nice to be able to see them in one place instead of hiding in comments...
Sep 24 2016
Sep 21 2016
We use a text field for a 'reference number' which refers to tasks imported from bugzilla reference=bz123, or RT with reference=rt456
Sep 19 2016
Here are 2 use-cases which are both essentially the same in all the important ways:
Sep 18 2016
@epriestley: Are you open to patches that add more information to the calendar.event.search response? It currently does not even include the event time which is a pretty crucial detail to make the results useful.
Sep 14 2016
Sep 10 2016
Sep 9 2016
Sep 7 2016
IMO, Pokémon catching is an essential feature, please implement that first.
T10612: Editing a panel causes it to duplicate in dashboard may be the same root cause as this bug.
Ut seems to be T10145
I'm also seeing this bug.
I think this change broke dashboard editing slightly. Now when adding a panel to a dashboard column, the same panel gets added twice, once for each column. Removing either of the dupes removes both.
Aug 30 2016
Aug 27 2016
This would be awesome.
Jul 28 2016
Jul 27 2016
I guess what I'm saying is if the E100/4 monogram format was always used then it would at least be consistent and the phid could still be assigned automatically as this revision implements. Maybe I'm missing something - does edit engine absolutely require that every object has a numeric ID as well as a PHID?
@epriestley: Does an object necessarily have to have a unique monogram in order to have a phid? (I don't think so, sort of a rhetorical question)
Jul 20 2016
This looks good to me, and I agree that it makes a lot more sense to use AND rather than OR when building the HAVING clause.
Jul 19 2016
I think the root problem here is that "Herald added a subscriber: $user" is seen as email-spammy yet people are unwilling to edit their preferences to disable notifications for subscription-changes.
Jul 15 2016
- Don't show commits twice in task details.
I misplaced the end of the if (!$task_graph->isEmpty()) block
I misplaced the end of the if (!$task_graph->isEmpty()) block
Jul 14 2016
It might be useful if the dependency resolution was only two-levels deep. That wouldn't really solve the problem for extremely wide trees though.
Jul 13 2016
Needs a check for empty and at least a better error message in DiffusionBrowseQueryConduitAPIMethod.php:115
We are seeing this as well when attempting to browse an empty commit: https://phabricator.wikimedia.org/T140236
Jul 11 2016
This is now deployed on the WMF phabricator, you can see it in action here - look for the arrow buttons in the upper-right corner of the event view.
Jul 7 2016
@epriestley - this is caused by a downstream patch which intentionally excludes sprints from the displayed groups.
Jun 30 2016
@chad: indeed, word-break: break-all on the .differential-diff td element seems to do the trick.
Regression possibly caused by this: https://phabricator.wikimedia.org/T137394
Jun 25 2016
Jun 20 2016
Relatedly: it would be nice if milestones copied the settings of previous milestones, sort of a pseudo template behavior, where milestone2 copied the defaults from milestone1 automatically (so that if you set a series to default to the workboard, every newly created milestone would share that setting unless you override the default)
Personally I'm using milestones to represent releases and the workboard is the farthest thing from what I'd want to show when clicking on the milestone.
Jun 16 2016
Jun 13 2016
Jun 10 2016
Jun 9 2016
Here's what happens when adding wikidata project tag using the comment form typeahead:
May 31 2016
Simply adding a tabindex=1 to the search input box seems to at least make the search box focusable, however, it's not as good as the global shortcut which works regardless of where focus is on the page.
This is a pretty major regression on Firefox+Gnome. I am no longer able to focus the search input with the keyboard. Tab doesn't work no matter how many times I tab I am only able to select text links. The search box does not appear to be anywhere in the tab order. OSX keyboard selection behavior is the weird edge case, not the norm.
So I'm confused, "tab" does not focus the search box for me. A keyboard shortcut to focus the search box is very useful. Surely more than 6 people used it?
May 19 2016
May 11 2016
@epriestley: Thanks for the tips. That field is actually a legacy thing at this point and probably should just be hidden everywhere.