Page MenuHomePhabricator

Implement BYSETPOS for YEARLY and MONTHLY RRULES
ClosedPublic

Authored by epriestley on Sep 28 2016, 2:18 AM.
Tags
None
Referenced Files
F14035294: D16617.diff
Sun, Nov 10, 5:21 AM
F14020066: D16617.diff
Tue, Nov 5, 11:55 PM
F13975385: D16617.diff
Fri, Oct 18, 9:54 AM
Unknown Object (File)
Sep 20 2024, 11:32 PM
Unknown Object (File)
Sep 18 2024, 1:22 PM
Unknown Object (File)
Sep 17 2024, 6:47 PM
Unknown Object (File)
Sep 15 2024, 1:02 PM
Unknown Object (File)
Sep 12 2024, 11:30 AM
Subscribers
None

Details

Summary

Ref T10747. I may come back and try to clean this up, but at least make all the tests pass.

This stuff is really messy because if you have a YEARLY rule like "the 3rd of every month", and BYSETPOS on it, and the first instance is in June, too bad: we have to build every event for the whole year to apply BYSETPOS.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement BYSETPOS for YEARLY and MONTHLY RRULES.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 2:27 AM
This revision was automatically updated to reflect the committed changes.