Page MenuHomePhabricator
Differential D16610

Fix some RRULE bugs with BYWEEKNO
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 11:39 PM.
Tags
None
Referenced Files
F19822875: D16610.diff
Mar 7 2026, 9:04 AM
F19304604: D16610.diff
Dec 24 2025, 1:28 PM
F18953538: D16610.diff
Nov 12 2025, 7:46 AM
F18769446: D16610.diff
Oct 8 2025, 7:41 AM
F18767018: D16610.id.diff
Oct 7 2025, 8:14 PM
F18763605: D16610.id40000.diff
Oct 7 2025, 1:03 AM
F18757908: D16610.id40000.diff
Oct 5 2025, 8:01 PM
F18755410: D16610.diff
Oct 5 2025, 5:25 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHU9db0dd4fe2fd: Fix some RRULE bugs with BYWEEKNO
Summary

Ref T10747. A few typos, plus we need to expand months, plus the initial week calculation was slightly wrong.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39983.Sep 27 2016, 11:39 PM
epriestley retitled this revision from to Fix some RRULE bugs with BYWEEKNO.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Sep 28 2016, 12:08 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 12:08 AM
Closed by commit rPHU9db0dd4fe2fd: Fix some RRULE bugs with BYWEEKNO (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
11 lines
__tests__/
50 lines

Diff 40000

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Loading...
View Options

src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php

Loading...
Phabricator · Built by Phacility