HomePhabricator

Fix an RRULE bug with day cursors and skipped months

Description

Fix an RRULE bug with day cursors and skipped months

Summary:
Ref T10747. This rule wasn't quite correct, and got some things like BYMONTH=1,3;INTERVAL=9 wrong.

Instead of resetting the day cursor to 1, we need to move it forward through time in INTERVAL jumps until we get to the next candidate month.

Test Plan: Unit tests now pass.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16619

Details

Provenance
epriestleyAuthored on Sep 28 2016, 2:14 PM
epriestleyPushed on Sep 28 2016, 10:02 PM
Reviewer
chad
Differential Revision
D16619: Fix an RRULE bug with day cursors and skipped months
Parents
rPHU1a5bbe5971cc: Implement BYSETPOS for YEARLY and MONTHLY RRULES
Branches
Unknown
Tags
Unknown
Tasks
T10747: Import and export ICS from Calendar
Build Status
Buildable 13909
Build 18005: Run Core Tests