Page MenuHomePhabricator

Export recurring events and build ICS files for configured exports
ClosedPublic

Authored by epriestley on Oct 6 2016, 8:14 PM.
Tags
None
Referenced Files
F15469881: D16679.diff
Fri, Apr 4, 5:45 PM
F15460861: D16679.id40158.diff
Tue, Apr 1, 3:01 AM
F15436709: D16679.id.diff
Tue, Mar 25, 4:06 PM
F15430544: D16679.diff
Mon, Mar 24, 8:04 AM
F15426854: D16679.id40156.diff
Sun, Mar 23, 11:11 AM
F15383124: D16679.diff
Fri, Mar 14, 3:37 PM
F15321421: D16679.id40158.diff
Thu, Mar 6, 10:57 PM
Unknown Object (File)
Feb 22 2025, 12:11 AM
Subscribers
None

Details

Summary

Ref T10747. This:

  • Exports recurring events properly, with RRULE + RECURRENCE-ID.
  • When exporting a part of an event series, export the whole series to ICS so it is represented faithfully.
  • Make the subscribable URL for "Export" objects work.
Test Plan
  • Downloaded the ".ics" for a normal event, imported it into Calendar.app and Google Calendar.
  • Downloaded the ".ics" for a recurring event, imported it into Calendar.app and Google Calendar.
  • Defined an ".ics" Export of my events, subscribed to them in Calendar.app.
    • Edited an event in Phabricator.
    • Hit +R in Calendar.app, saw changes. (MAGIC!)
    • This export included recurring events, which appeared the same way in Calendar.app and Phabricator.
  • Can't import into Google Calendar from my local install easily since Google's servers can't hit my laptop, but I'll test once we deploy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Export recurring events and build ICS files for configured exports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.