Add a very basic ICS syntax parser
0107c187b6d8
Actions

Description

Add a very basic ICS syntax parser

Summary:
Ref T10747. Extremely rough parser for ICS syntax, based on RFC5545 + RFC6868.

This doesn't understand any of the content in an ICS file or know anything about calendaring or events yet, it just applies all the weird linewrapping, escaping, typing and parsing rules.

I'll refine this to be less bad and eventually do useful things, but I got a basic test case running at least.

Test Plan:

Added unit test.
Ran unit test.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16520

Details

Provenance

epriestley	Authored on Sep 8 2016, 8:29 PM
epriestley	Pushed on Sep 9 2016, 12:17 AM

Reviewer

chad

Differential Revision

D16520: Add a very basic ICS syntax parser

Parents

rPHUf983effe304c: When stopping subprocesses, send SIGTERM first, then SIGKILL if that doesn't…

Branches

Unknown

Tags

Unknown

Tasks

T10747: Import and export ICS from Calendar

Build Status

Buildable 13648
Build 17593: Run Core Tests

Event Timeline

epriestley committed rPHU0107c187b6d8: Add a very basic ICS syntax parser (authored by epriestley).Sep 9 2016, 12:17 AM

epriestley added a task: T10747: Import and export ICS from Calendar.

Harbormaster failed to build B13648: rPHU0107c187b6d8: Add a very basic ICS syntax parser!Sep 9 2016, 12:18 AM

shipitquick

That build failure is some kind of weird race related to the SIGTERM/SIGKILL stuff, not actually this change's fault. Looking at it.

happycat

Harbormaster failed to build B13648: rPHU0107c187b6d8: Add a very basic ICS syntax parser!Sep 9 2016, 12:24 AM

Harbormaster completed building B13648: rPHU0107c187b6d8: Add a very basic ICS syntax parser.Sep 9 2016, 12:27 AM

I can't reproduce the failure; if that test keeps failing I'll just throw it away. There's basically no way it could break without everything in the world immediately breaking, and it's inherently race-prone if the box happens to be under a lot of load or whatever when it runs.

dfumagalli mentioned this in T11613: New install exception is wrong if preflight setup checks fail.Sep 10 2016, 7:12 PM

dfumagalli mentioned this in T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.Sep 12 2016, 7:27 PM