Differential D16761

Parse (and discard) VALARM sections in ICS files
ClosedPublic
Actions

Authored by epriestley on Oct 27 2016, 8:08 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar
T11790: "VALARM" in ics makes phabricator fail parsing

Commits

rPHU1961d5518822: (stable) Promote 2016 Week 44
rPHUdaeaed6bfbc3: Parse (and discard) VALARM sections in ICS files

Summary

Ref T10747. Ref T11790. These sections may legally appear inside VEVENT sections.

For now, parse but discard them. At least for now, we assume whatever you're importing from is authoritative and handles notifying you if you're importing events.

(It also probably makes more sense to set per-import or per-user notification settings than trust VALARMS? But we can cross that bridge when we come to it.)

Test Plan

Added unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40364.Oct 27 2016, 8:08 PM

epriestley retitled this revision from to Parse (and discard) VALARM sections in ICS files.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T11790: "VALARM" in ics makes phabricator fail parsing, T10747: Import and export ICS from Calendar.

punt

chad accepted this revision.Oct 27 2016, 8:18 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 27 2016, 8:18 PM

I don't really know what we'd do with this anyway:

BEGIN:VALARM
ACTION:EMAIL
SUMMARY:Amazing SEO Results!
DESCRIPTION:Click here to get amazing SEO results! Wow! Amazing!
ATTENDEE:mailto:jsmith@gmail.com
<many many more email addresses>
ATTACH;ENCODING=BASE64;VALUE=BINARY:<not_a_virus.exe base64 encoded>
END:VALARM

...which, interpreted according to the RFC, requires us to send viruses and spam to arbitrary users immediately. 1996 was a simpler time.