Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.
Tags
None
Referenced Files
F19060841: D20515.diff
Sat, Nov 29, 10:26 AM
F18875823: D20515.id.diff
Wed, Nov 5, 7:36 PM
F18868962: D20515.diff
Tue, Nov 4, 9:23 AM
F18851323: D20515.id48908.diff
Oct 30 2025, 11:53 PM
F18818457: D20515.diff
Oct 22 2025, 12:28 AM
F18743768: D20515.id.diff
Oct 3 2025, 12:49 AM
F18742496: D20515.id.diff
Oct 2 2025, 7:42 PM
F18737246: D20515.diff
Oct 1 2025, 9:39 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable