Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 4:24 PM
Unknown Object (File)
May 9 2025, 10:46 PM
Unknown Object (File)
May 8 2025, 7:22 PM
Unknown Object (File)
May 7 2025, 10:14 AM
Unknown Object (File)
Apr 29 2025, 1:38 PM
Unknown Object (File)
Apr 13 2025, 1:57 PM
Unknown Object (File)
Apr 7 2025, 7:17 PM
Unknown Object (File)
Apr 6 2025, 9:37 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable