Differential D20515

Call `$linter->setEngine` in linter tests
ClosedPublic
Actions

Authored by joshuaspence on Mon, May 13, 4:27 AM.

Details

Reviewers

Group Reviewers

Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence created this revision.Mon, May 13, 4:27 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMon, May 13, 4:27 AM

Harbormaster completed remote builds in B22781: Diff 48908.Mon, May 13, 4:28 AM

joshuaspence requested review of this revision.Mon, May 13, 4:28 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMon, May 13, 4:28 AM

epriestley accepted this revision.Tue, May 14, 2:09 PM

This revision is now accepted and ready to land.Tue, May 14, 2:09 PM

Closed by commit rARC4f583dded366: Call `$linter->setEngine` in linter tests (authored by joshuaspence). · Explain WhyTue, May 14, 11:02 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added an edge: rARC4f583dded366: Call `$linter->setEngine` in linter tests.

Revision Contents
Changeset List

			Path	Packages
M			src/lint/linter/__tests__/ArcanistLinterTestCase.php (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48908	9830c93		Mon, May 13, 4:27 AM	★	★
Diff 2	48923	9ccbbee	rARC4f583dded366af8b2b316414bfc100063e580866	Tue, May 14, 11:01 PM	★	★

Diff 48923

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Call `$linter->setEngine` in linter testsClosedPublicActions