Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.
Tags
None
Referenced Files
F15468469: D20515.id.diff
Fri, Apr 4, 12:59 AM
F15465556: D20515.diff
Wed, Apr 2, 8:35 PM
F15434638: D20515.diff
Tue, Mar 25, 4:46 AM
F15424238: D20515.id48923.diff
Sat, Mar 22, 9:04 PM
F15395580: D20515.id48908.diff
Sun, Mar 16, 8:10 AM
F15316457: D20515.diff
Thu, Mar 6, 6:41 PM
Unknown Object (File)
Feb 26 2025, 9:21 PM
Unknown Object (File)
Feb 9 2025, 10:59 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable