Let "phlog()" log Throwables
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 9:18 PM.

Tags

None

Referenced Files

	F18746898: D20143.id.diff
	Fri, Oct 3, 1:53 PM

	F18738518: D20143.diff
	Wed, Oct 1, 3:56 PM

	F18628456: D20143.id48102.diff
	Tue, Sep 16, 6:22 AM

	F18627404: D20143.diff
	Tue, Sep 16, 3:55 AM

	F18569398: D20143.id48102.diff
	Wed, Sep 10, 1:37 AM

	F18569397: D20143.id48087.diff
	Wed, Sep 10, 1:37 AM

	F18438845: D20143.id.diff
	Aug 31 2025, 1:48 PM

	F18420335: D20143.diff
	Aug 30 2025, 4:09 PM

View All Files

Subscribers

None

Tokens

"100" token, awarded by joshuaspence.

Details

Reviewers

amckinley

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rPHU8151b3a30e7e: (stable) Let "phlog()" log Throwables
rPHUf430af3cd431: Let "phlog()" log Throwables

Summary

Ref T13250. If you "phlog()" a Throwable, it doesn't recognize that it's an exception and sends you down the "unknown type of object" pathway. You get a one-line "Object Error" message in the log.

Instead, treat it more like an Exception and log a message + stack trace.

Test Plan

Logged some Throwables, got sensible information about them.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 11 2019, 9:18 PM

Harbormaster completed remote builds in B21926: Diff 48087.Feb 11 2019, 9:19 PM

epriestley requested review of this revision.Feb 11 2019, 9:19 PM

amckinley accepted this revision.Feb 11 2019, 11:11 PM

This revision is now accepted and ready to land.Feb 11 2019, 11:11 PM

It looks like passing a Throwable as $previous is actually fine everywhere (https://3v4l.org/U2B1v) but it doesn't really matter and I'm sure if we do it they'll break it in PHP 7.4 or something so ¯\_(ツ)_/¯