Page MenuHomePhabricator

Let "phlog()" log Throwables
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 5:34 AM
Unknown Object (File)
Fri, Jun 24, 10:37 AM
Unknown Object (File)
Fri, Jun 24, 8:49 AM
Unknown Object (File)
Thu, Jun 23, 11:38 AM
Unknown Object (File)
Thu, Jun 23, 1:05 AM
Unknown Object (File)
Wed, Jun 22, 3:15 AM
Unknown Object (File)
Tue, Jun 21, 6:11 AM
Unknown Object (File)
Fri, Jun 10, 12:03 PM
Subscribers
None
Tokens
"100" token, awarded by joshuaspence.

Details

Summary

Ref T13250. If you "phlog()" a Throwable, it doesn't recognize that it's an exception and sends you down the "unknown type of object" pathway. You get a one-line "Object Error" message in the log.

Instead, treat it more like an Exception and log a message + stack trace.

Test Plan

Logged some Throwables, got sensible information about them.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 11 2019, 11:11 PM

It looks like passing a Throwable as $previous is actually fine everywhere (https://3v4l.org/U2B1v) but it doesn't really matter and I'm sure if we do it they'll break it in PHP 7.4 or something so ¯\_(ツ)_/¯

This revision was automatically updated to reflect the committed changes.