Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 3, 11:10 PM
Unknown Object (File)
Jun 2 2026, 10:36 PM
Unknown Object (File)
Jun 1 2026, 6:15 PM
Unknown Object (File)
Apr 2 2026, 4:25 PM
Unknown Object (File)
Apr 2 2026, 4:24 PM
Unknown Object (File)
Mar 6 2026, 1:43 PM
Unknown Object (File)
Mar 5 2026, 3:28 PM
Unknown Object (File)
Jan 11 2026, 1:28 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit