Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 6 2025, 6:21 AM
Unknown Object (File)
Jun 5 2025, 4:25 PM
Unknown Object (File)
May 10 2025, 6:58 AM
Unknown Object (File)
May 7 2025, 7:03 AM
Unknown Object (File)
Apr 14 2025, 8:26 PM
Unknown Object (File)
Apr 11 2025, 12:45 PM
Unknown Object (File)
Apr 11 2025, 12:37 PM
Unknown Object (File)
Apr 10 2025, 4:24 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit