Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F18918587: D20542.id.diff
Nov 9 2025, 10:59 AM
F18902493: D20542.diff
Nov 8 2025, 1:32 AM
F18818530: D20542.diff
Oct 22 2025, 12:46 AM
F18770302: D20542.id.diff
Oct 8 2025, 11:50 AM
F18761588: D20542.id48987.diff
Oct 6 2025, 3:16 PM
F18656410: D20542.id48988.diff
Sep 22 2025, 10:25 PM
F18574462: D20542.id.diff
Sep 10 2025, 10:43 AM
F18271659: D20542.diff
Aug 22 2025, 4:39 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit