Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F14538571: D20542.diff
Tue, Jan 7, 3:46 AM
Unknown Object (File)
Sat, Dec 28, 2:12 PM
Unknown Object (File)
Wed, Dec 18, 12:15 AM
Unknown Object (File)
Sat, Dec 14, 5:36 PM
Unknown Object (File)
Sun, Dec 8, 3:01 PM
Unknown Object (File)
Dec 7 2024, 11:20 AM
Unknown Object (File)
Dec 5 2024, 3:29 PM
Unknown Object (File)
Nov 25 2024, 3:51 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit