Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F15470828: D20542.id.diff
Sat, Apr 5, 1:43 AM
F15469737: D20542.id48988.diff
Fri, Apr 4, 4:00 PM
F15469736: D20542.id48987.diff
Fri, Apr 4, 4:00 PM
F15466916: D20542.id.diff
Thu, Apr 3, 10:47 AM
F15465561: D20542.diff
Wed, Apr 2, 8:36 PM
F15465369: D20542.diff
Wed, Apr 2, 5:55 PM
F15415184: D20542.id48988.diff
Thu, Mar 20, 4:41 AM
F15412883: D20542.diff
Wed, Mar 19, 3:32 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit