Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F18574462: D20542.id.diff
Wed, Sep 10, 10:43 AM
F18271659: D20542.diff
Fri, Aug 22, 4:39 PM
F18100530: D20542.id.diff
Aug 9 2025, 11:56 AM
F17715907: D20542.id48987.diff
Jul 17 2025, 3:27 PM
Unknown Object (File)
Jun 6 2025, 6:21 AM
Unknown Object (File)
Jun 5 2025, 4:25 PM
Unknown Object (File)
May 10 2025, 6:58 AM
Unknown Object (File)
May 7 2025, 7:03 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit