Differential D11773

[Draft] Convert `ArcanistScriptAndRegexLinter` to `ArcanistExternalLinter`
AbandonedPublic
Actions

Authored by joshuaspence on Feb 15 2015, 8:28 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

WIP. Depends on D10704.

Test Plan

WIP

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	resources/grep_linter.php:52	TXT3	Line Too Long
Advice	resources/grep_linter.php:52	XHP14	Misuse of preg_quote()
Advice	src/lint/linter/ArcanistScriptAndRegexLinter.php:261	XHP16	TODO Comment

Unit

Test Failures

Build Status

Buildable 6232
Build 6253: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	28 ms	ArcanistScriptAndRegexLinterTestCase::testLinter
	1,109 ms	ArcanistCSSLintLinterTestCase::testLinter
	110 ms	ArcanistCSSLintLinterTestCase::testVersion
	17 ms	ArcanistChmodLinterTestCase::testLinter
	270 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 47 Passed · 9 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 28382.Feb 15 2015, 8:28 PM

joshuaspence retitled this revision from to Convert `ArcanistScriptAndRegexLinter` to `ArcanistExternalLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a parent revision: D10704: Modernize Script-and-Regex linter for ConfigurationDriven.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 15 2015, 8:28 PM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence mentioned this in D10704: Modernize Script-and-Regex linter for ConfigurationDriven.Feb 15 2015, 8:29 PM

johnny-bit added a subscriber: johnny-bit.Feb 15 2015, 8:52 PM

Start adding some tests

joshuaspence retitled this revision from Convert `ArcanistScriptAndRegexLinter` to `ArcanistExternalLinter` to [Draft] Convert `ArcanistScriptAndRegexLinter` to `ArcanistExternalLinter`.Feb 28 2015, 10:52 PM