Page MenuHomePhabricator

Allow daemons to be run in the foreground
AbandonedPublic

Authored by joshuaspence on Mon, Jul 8, 3:00 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently there's no way to run all daemons in the foreground.

  • bin/phd start executes all daemons in the background.
  • bin/phd launch executes a single daemon in the background.
  • bin/phd debug executes a single daemon in the foreground, but also enables verbose log output.

Add a --foreground flag to bin/phd start and bin/phd launch to allow daemons to be executed in the foreground. I plan to use this as an entrypoint in a Docker container.

Test Plan

Ran the following commands alongside bin/worker flood and verified that daemons were functional:

    • bin/phd start
  • bin/phd start --foreground
  • bin/phd launch task
  • bin/phd launch --foreground task
  • bin/phd debug task

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint OK
Unit
Unit Tests Skipped
Build Status
Buildable 23114
Build 31736: Run Core Tests
Build 31735: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Mon, Jul 8, 3:00 AM
joshuaspence added inline comments.Mon, Jul 8, 3:01 AM
src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
25

Unrelated fix

joshuaspence requested review of this revision.Mon, Jul 8, 3:02 AM
epriestley requested changes to this revision.Mon, Jul 8, 3:10 PM

We don't have any customer use cases for this so I'm not interested in bringing it upstream at this time.

This revision now requires changes to proceed.Mon, Jul 8, 3:10 PM
joshuaspence abandoned this revision.Mon, Jul 8, 6:20 PM