Page MenuHomePhabricator
Differential D14482

Improve FontAwesome icons
AbandonedPublic
Actions

Authored by joshuaspence on Nov 14 2015, 7:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 11:28 PM
Unknown Object (File)
Mon, Dec 9, 3:25 AM
Unknown Object (File)
Dec 7 2024, 1:09 AM
Unknown Object (File)
Dec 5 2024, 2:56 AM
Unknown Object (File)
Dec 1 2024, 2:31 PM
Unknown Object (File)
Dec 1 2024, 7:54 AM
Unknown Object (File)
Nov 4 2024, 10:07 AM
Unknown Object (File)
Nov 4 2024, 10:07 AM
View All Files
Subscribers
hach-que
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Summary

Give all PHID types and applications a unique FontAwesome icon.

Test Plan

Viewed icons at /config/module/phid/.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/base/PhabricatorApplication.php:300XHP86Unsafe Usage of Dynamic String
Errorsrc/applications/base/PhabricatorApplication.php:302XHP86Unsafe Usage of Dynamic String
Unit
Tests Passed
Build Status
Buildable 8834
Build 10313: Run Core Tests
Build 10312: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35024.Nov 14 2015, 7:10 AM
joshuaspence retitled this revision from to Improve FontAwesome icons.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, chad.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 14 2015, 7:10 AM
Herald added subscribers: hach-que, Korvin. · View Herald Transcript
chad requested changes to this revision.EditedNov 14 2015, 1:48 PM
chad edited edge metadata.

What are we doing this for? I don't see a related task and am about to go on vacation. i'd like to understand the needs here.

This revision now requires changes to proceed.Nov 14 2015, 1:48 PM
joshuaspence abandoned this revision.May 17 2019, 1:51 AM

Not actively working on this.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
phid/
4 lines
4 lines
4 lines
4 lines
4 lines
auth/
application/
2 lines
phid/
4 lines
4 lines
4 lines
badges/
phid/
4 lines
base/
2 lines
calendar/
phid/
4 lines
config/
phid/
4 lines
conpherence/
phid/
4 lines
countdown/
phid/
4 lines
dashboard/
phid/
4 lines
4 lines
differential/
phid/
4 lines
4 lines
diviner/
phid/
8 lines
drydock/
phid/
4 lines
2 lines
4 lines
2 lines
files/
application/
2 lines
phid/
4 lines
fund/
phid/
6 lines
4 lines
harbormaster/
phid/
4 lines
4 lines
4 lines
2 lines
4 lines
4 lines
4 lines
herald/
phid/
4 lines
maniphest/
phid/
4 lines
meta/
phid/
2 lines
metamta/
application/
2 lines
phid/
4 lines
nuance/
phid/
4 lines
4 lines
4 lines
4 lines
oauthserver/
phid/
4 lines
4 lines
owners/
phid/
2 lines
passphrase/
phid/
4 lines
paste/
phid/
4 lines
people/
phid/
4 lines
2 lines
phame/
phid/
4 lines
4 lines
phid/
2 lines
phlux/
phid/
4 lines
pholio/
phid/
4 lines
4 lines
phortune/
phid/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
phragment/
application/
2 lines
phid/
4 lines
4 lines
4 lines
phriction/
phid/
4 lines
phurl/
phid/
4 lines
policy/
application/
4 lines
phid/
4 lines
ponder/
phid/
4 lines
4 lines
project/
phid/
2 lines
releeph/
phid/
4 lines
4 lines
4 lines
repository/
phid/
4 lines
4 lines
4 lines
4 lines
slowvote/
phid/
4 lines
spaces/
application/
2 lines
phid/
4 lines
tokens/
phid/
4 lines
transactions/
application/
4 lines
phid/
4 lines
4 lines
infrastructure/
daemon/
workers/
phid/
4 lines
4 lines

Diff 35024

View Options

src/applications/almanac/phid/AlmanacBindingPHIDType.php

Loading...
View Options

src/applications/almanac/phid/AlmanacDevicePHIDType.php

Loading...
View Options

src/applications/almanac/phid/AlmanacInterfacePHIDType.php

Loading...
View Options

src/applications/almanac/phid/AlmanacNetworkPHIDType.php

Loading...
View Options

src/applications/almanac/phid/AlmanacServicePHIDType.php

Loading...
View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php

Loading...
View Options

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

Loading...
View Options

src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php

Loading...
View Options

src/applications/badges/phid/PhabricatorBadgesPHIDType.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

Loading...
View Options

src/applications/config/phid/PhabricatorConfigConfigPHIDType.php

Loading...
View Options

src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php

Loading...
View Options

src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php

Loading...
View Options

src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php

Loading...
View Options

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

Loading...
View Options

src/applications/differential/phid/DifferentialDiffPHIDType.php

Loading...
View Options

src/applications/differential/phid/DifferentialRevisionPHIDType.php

Loading...
View Options

src/applications/diviner/phid/DivinerAtomPHIDType.php

Loading...
View Options

src/applications/drydock/phid/DrydockAuthorizationPHIDType.php

Loading...
View Options

src/applications/drydock/phid/DrydockLeasePHIDType.php

Loading...
View Options

src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php

Loading...
View Options

src/applications/drydock/phid/DrydockResourcePHIDType.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/phid/PhabricatorFileFilePHIDType.php

Loading...
View Options

src/applications/fund/phid/FundBackerPHIDType.php

Loading...
View Options

src/applications/fund/phid/FundInitiativePHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

Loading...
View Options

src/applications/herald/phid/HeraldRulePHIDType.php

Loading...
View Options

src/applications/maniphest/phid/ManiphestTaskPHIDType.php

Loading...
View Options

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

Loading...
View Options

src/applications/metamta/application/PhabricatorMetaMTAApplication.php

Loading...
View Options

src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php

Loading...
View Options

src/applications/nuance/phid/NuanceItemPHIDType.php

Loading...
View Options

src/applications/nuance/phid/NuanceQueuePHIDType.php

Loading...
View Options

src/applications/nuance/phid/NuanceRequestorPHIDType.php

Loading...
View Options

src/applications/nuance/phid/NuanceSourcePHIDType.php

Loading...
View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php

Loading...
View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php

Loading...
View Options

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

Loading...
View Options

src/applications/passphrase/phid/PassphraseCredentialPHIDType.php

Loading...
View Options

src/applications/paste/phid/PhabricatorPastePastePHIDType.php

Loading...
View Options

src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php

Loading...
View Options

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

Loading...
View Options

src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php

Loading...
View Options

src/applications/phame/phid/PhabricatorPhamePostPHIDType.php

Loading...
View Options

src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php

Loading...
View Options

src/applications/phlux/phid/PhluxVariablePHIDType.php

Loading...
View Options

src/applications/pholio/phid/PholioImagePHIDType.php

Loading...
View Options

src/applications/pholio/phid/PholioMockPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneAccountPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneCartPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneChargePHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneMerchantPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneProductPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortunePurchasePHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

Loading...
View Options

src/applications/phragment/application/PhabricatorPhragmentApplication.php

Loading...
View Options

src/applications/phragment/phid/PhragmentFragmentPHIDType.php

Loading...
View Options

src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php

Loading...
View Options

src/applications/phragment/phid/PhragmentSnapshotPHIDType.php

Loading...
View Options

src/applications/phriction/phid/PhrictionDocumentPHIDType.php

Loading...
View Options

src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php

Loading...
View Options

src/applications/policy/application/PhabricatorPolicyApplication.php

Loading...
View Options

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

Loading...
View Options

src/applications/ponder/phid/PonderAnswerPHIDType.php

Loading...
View Options

src/applications/ponder/phid/PonderQuestionPHIDType.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

Loading...
View Options

src/applications/releeph/phid/ReleephBranchPHIDType.php

Loading...
View Options

src/applications/releeph/phid/ReleephProductPHIDType.php

Loading...
View Options

src/applications/releeph/phid/ReleephRequestPHIDType.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php

Loading...
View Options

src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php

Loading...
View Options

src/applications/spaces/application/PhabricatorSpacesApplication.php

Loading...
View Options

src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php

Loading...
View Options

src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php

Loading...
View Options

src/applications/transactions/application/PhabricatorTransactionsApplication.php

Loading...
View Options

src/applications/transactions/phid/PhabricatorApplicationTransactionTransactionPHIDType.php

Loading...
View Options

src/applications/transactions/phid/PhabricatorEditEngineConfigurationPHIDType.php

Loading...
View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php

Loading...
View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

Loading...
Phabricator · Built by Phacility