Page MenuHomePhabricator

Let the top-level exception handler dump a stack trace if we reach debug mode before things go sideways
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 3, 12:51 AM
Unknown Object (File)
Sun, Jun 26, 2:31 PM
Unknown Object (File)
Sat, Jun 25, 10:01 PM
Unknown Object (File)
Fri, Jun 24, 10:37 AM
Unknown Object (File)
Wed, Jun 15, 7:57 PM
Unknown Object (File)
Fri, Jun 10, 4:48 PM
Unknown Object (File)
Wed, Jun 8, 9:39 PM
Unknown Object (File)
Wed, Jun 8, 10:16 AM
Subscribers
None
Tokens
"100" token, awarded by joshuaspence.

Details

Summary

Depends on D20140. Ref T13250. Currently, the top-level exception handler doesn't dump stacks because we might not be in debug mode, and we might double-extra-super fatal if we call PhabricatorEnv:... to try to figure out if we're in debug mode or not.

We can get around this by setting a flag on the Sink once we're able to confirm that we're in debug mode. Then it's okay for the top-level error handler to show traces.

There's still some small possibility that showing a trace could make us double-super-fatal since we have to call a little more code, but AphrontStackTraceView is pretty conservative about what it does and 99% of the time this is a huge improvement.

Test Plan

Screen Shot 2019-02-11 at 1.00.45 PM.png (1×1 px, 350 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/aphront/sink/AphrontHTTPSink.php
7–8

I just happened to notice this "do install" typo.

This revision is now accepted and ready to land.Feb 11 2019, 11:05 PM
  • Just remove that comment since we don't do either one, even though they're technically possible.
This revision was automatically updated to reflect the committed changes.