Diffusion Arcanist 82445bb60534

Let lint rules support anonymous classes
82445bb60534
Actions

Description

Let lint rules support anonymous classes

Summary: Ref T4334. Depends on D19740. Improve some lint rules so they can handle anonymous classes.

Test Plan: Ran updated tests

Reviewers: joshuaspence, Blessed Reviewers, epriestley

Reviewed By: joshuaspence, Blessed Reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4334

Differential Revision: https://secure.phabricator.com/D19741

Details

Provenance

wjiang	Authored on May 15 2019, 1:07 AM
joshuaspence	Committed on May 15 2019, 1:11 AM
joshuaspence	Pushed on May 15 2019, 1:11 AM

Reviewer

Blessed Reviewers

Parents

rARC6a8e76db329e: Allow `buildFutures` and `resolveFutures` to be overridden

Branches

Unknown

Tags

Unknown

Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Build Status

Buildable 22800
Build 31276: Run Core Tests

Event Timeline

joshuaspence committed rARC82445bb60534: Let lint rules support anonymous classes (authored by wjiang).May 15 2019, 1:11 AM

joshuaspence added a commit: D19741: Let lint rules support anonymous classes.

joshuaspence added a task: T4334: Support PHP5.4+ syntax in XHPAST.

Harbormaster completed building B22800: rARC82445bb60534: Let lint rules support anonymous classes.May 15 2019, 1:11 AM

epriestley mentioned this in 2019 Week 20 (Late May).May 16 2019, 9:00 PM

Changes (8)

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistClassNameLiteralXHPASTLinterRule.php

ArcanistConstructorParenthesesXHPASTLinterRule.php

ArcanistSelfClassReferenceXHPASTLinterRule.php

ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

__tests__/

class-name-literal/

class-name-literal.lint-test

constructor-parentheses/

constructor-parentheses.lint-test

self-class-reference/

self-class-references.lint-test

unnecessary-final-modifier/

unnecessary-final-modifier.lint-test

rARC82445bb60534

View Options

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/class-name-literal/class-name-literal.lint-test

View Options

src/lint/linter/xhpast/rules/tests/constructor-parentheses/constructor-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

View Options

src/lint/linter/xhpast/rules/tests/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

Let lint rules support anonymous classes82445bb60534Actions

Description

Details

Event Timeline

Changes (8)

rARC82445bb60534

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/class-name-literal/class-name-literal.lint-test

src/lint/linter/xhpast/rules/__tests__/constructor-parentheses/constructor-parentheses.lint-test

src/lint/linter/xhpast/rules/__tests__/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/__tests__/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

Let lint rules support anonymous classes
82445bb60534
Actions

src/lint/linter/xhpast/rules/tests/class-name-literal/class-name-literal.lint-test

src/lint/linter/xhpast/rules/tests/constructor-parentheses/constructor-parentheses.lint-test

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-final-modifier/unnecessary-final-modifier.lint-test