Differential D14616

Consolidate two linter rules
AbandonedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 9:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 9:35 PM

	Unknown Object (File)
	Sun, Dec 15, 8:01 AM

	Unknown Object (File)
	Wed, Dec 11, 7:16 AM

	Unknown Object (File)
	Dec 4 2024, 10:45 PM

	Unknown Object (File)
	Nov 28 2024, 2:34 AM

	Unknown Object (File)
	Nov 27 2024, 4:21 PM

	Unknown Object (File)
	Nov 20 2024, 5:26 PM

	Unknown Object (File)
	Nov 16 2024, 7:28 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

WIP

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9169
Build 10834: Run Core Tests
Build 10833: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	32 ms	ArcanistParenthesesSpacingXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	612 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	151 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	28 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	60 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 289 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35359.Nov 30 2015, 9:38 PM

joshuaspence retitled this revision from to Consolidate two linter rules.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 9:38 PM

Herald added a subscriber: epriestley. · View Herald Transcript

WIP

This revision now requires changes to proceed.Dec 22 2015, 1:35 PM

Not actively working on this.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 17 2019, 1:51 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistCallParenthesesXHPASTLinterRule.php

26 lines

ArcanistParenthesesSpacingXHPASTLinterRule.php

4 lines

__tests__/

call-parentheses/

array.lint-test

parentheses-spacing/

closure.lint-test

10 lines

function-call.lint-test

26 lines

function.lint-test

12 lines

Diff 35359

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/call-parentheses/array.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/closure.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/function-call.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/function.lint-test

Loading...