Differential D14616

Consolidate two linter rules
AbandonedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 9:38 PM.

Tags

None

Referenced Files

	F18254933: D14616.diff
	Thu, Aug 21, 11:05 PM

	F18085385: D14616.id35359.diff
	Tue, Aug 5, 7:11 PM

	F17930345: D14616.id.diff
	Jul 30 2025, 5:56 PM

	F17899534: D14616.diff
	Jul 29 2025, 8:40 AM

	Unknown Object (File)
	Jun 30 2025, 7:59 AM

	Unknown Object (File)
	Jun 2 2025, 2:44 AM

	Unknown Object (File)
	May 29 2025, 5:20 PM

	Unknown Object (File)
	May 28 2025, 12:26 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

WIP

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9169
Build 10834: Run Core Tests
Build 10833: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	32 ms	ArcanistParenthesesSpacingXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	612 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	151 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	28 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	60 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 289 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35359.Nov 30 2015, 9:38 PM

joshuaspence retitled this revision from to Consolidate two linter rules.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 9:38 PM

Herald added a subscriber: epriestley. · View Herald Transcript

WIP

This revision now requires changes to proceed.Dec 22 2015, 1:35 PM

Not actively working on this.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 17 2019, 1:51 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistCallParenthesesXHPASTLinterRule.php

26 lines

ArcanistParenthesesSpacingXHPASTLinterRule.php

4 lines

__tests__/

call-parentheses/

array.lint-test

parentheses-spacing/

closure.lint-test

10 lines

function-call.lint-test

26 lines

function.lint-test

12 lines

Diff 35359

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/call-parentheses/array.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/closure.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/function-call.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/function.lint-test

Loading...