Page MenuHomePhabricator

Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic

Authored by joshuaspence on Thu, May 16, 1:57 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22804
Build 31283: Run Core Tests
Build 31282: arc lint + arc unit