Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic
Actions

Authored by joshuaspence on May 16 2019, 1:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 16, 10:14 AM

	Unknown Object (File)
	Sun, Aug 16, 12:09 AM

	Unknown Object (File)
	Mon, Aug 3, 4:18 AM

	Unknown Object (File)
	Fri, Jul 31, 4:07 PM

	Unknown Object (File)
	Wed, Jul 29, 10:17 PM

	Unknown Object (File)
	Jul 9 2026, 4:54 PM

	Unknown Object (File)
	Jun 25 2026, 5:45 PM

	Unknown Object (File)
	Jun 21 2026, 9:59 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A