Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic
Actions

Authored by joshuaspence on May 16 2019, 1:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 4, 10:05 PM

	Unknown Object (File)
	Thu, Jan 2, 7:46 PM

	Unknown Object (File)
	Tue, Dec 31, 5:47 PM

	Unknown Object (File)
	Fri, Dec 20, 3:22 PM

	Unknown Object (File)
	Wed, Dec 11, 3:20 PM

	Unknown Object (File)
	Tue, Dec 10, 9:46 PM

	Unknown Object (File)
	Dec 7 2024, 11:19 AM

	Unknown Object (File)
	Nov 29 2024, 1:41 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A