Page MenuHomePhabricator

Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic

Authored by joshuaspence on May 16 2019, 1:57 AM.
Tags
None
Referenced Files
F18846710: D20523.diff
Wed, Oct 29, 8:41 PM
F18818470: D20523.diff
Wed, Oct 22, 12:31 AM
F18791698: D20523.id49032.diff
Thu, Oct 16, 4:58 PM
F18658302: D20523.id48931.diff
Sep 23 2025, 5:44 AM
F18653614: D20523.diff
Sep 21 2025, 2:35 PM
F18653576: D20523.diff
Sep 21 2025, 2:22 PM
F18653509: D20523.diff
Sep 21 2025, 2:09 PM
F18653482: D20523.diff
Sep 21 2025, 1:57 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
lint5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22905
Build 31424: Run Core Tests
Build 31423: arc lint + arc unit