Page MenuHomePhabricator

wjiang (Wenzheng Jiang)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 5:11 AM (159 w, 1 d)
Availability
Available

Recent Activity

Oct 10 2018

wjiang requested review of D19741: Let lint rules support anonymous classes.
Oct 10 2018, 12:04 AM
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19741: Let lint rules support anonymous classes.
Oct 10 2018, 12:04 AM · XHPAST
wjiang added a child revision for D19740: Fix class attribute node in anonymous class: D19741: Let lint rules support anonymous classes.
Oct 10 2018, 12:04 AM

Oct 9 2018

wjiang added a comment to D19740: Fix class attribute node in anonymous class.

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Oct 9 2018, 1:47 AM
wjiang updated the test plan for D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM
wjiang requested review of D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM · XHPAST

Oct 8 2018

wjiang added a reviewer for D19736: Add support for anonymous class: thaiphv.
Oct 8 2018, 12:53 AM
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19736: Add support for anonymous class.
Oct 8 2018, 12:51 AM · XHPAST
wjiang requested review of D19736: Add support for anonymous class.
Oct 8 2018, 12:51 AM

Sep 18 2017

wjiang added inline comments to D18621: Add support for nullable return types.
Sep 18 2017, 11:00 PM

Aug 6 2017

wjiang added a comment to D17783: Improve `ArcanistLinterStandardTestCase`.

Bump

Aug 6 2017, 11:03 PM
wjiang updated the summary of D17783: Improve `ArcanistLinterStandardTestCase`.
Aug 6 2017, 11:03 PM
wjiang retitled D18351: Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements from Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statemnts to Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.
Aug 6 2017, 12:56 PM
wjiang added a comment to D18351: Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.

Maybe the name of ArcanistNamespaceFirstStatementXHPASTLinterRule is not quite proper now ? Perhaps ArcanistNamespaceStatementPositionXHPASTLinterRule could be replacement.

Aug 6 2017, 12:56 PM
wjiang created D18351: Let `ArcanistNamespaceFirstStatementXHPASTLinterRule` support `declare` statements.
Aug 6 2017, 12:52 PM

May 16 2017

wjiang added a comment to T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
In T12716#223717, @chad wrote:

I assume this is T4334

May 16 2017, 3:03 AM · Bug Report
wjiang updated the task description for T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
May 16 2017, 2:07 AM · Bug Report
wjiang created T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
May 16 2017, 2:06 AM · Bug Report

May 4 2017

wjiang abandoned D17743: Add `setArgument` to `ArcanistWorkflow`.
May 4 2017, 5:31 AM
wjiang updated the diff for D17825: Let default parameters linter rule support `...` in variadic function.

Minor

May 4 2017, 2:14 AM
wjiang updated subscribers of D17825: Let default parameters linter rule support `...` in variadic function.
May 4 2017, 2:13 AM
wjiang created D17825: Let default parameters linter rule support `...` in variadic function.
May 4 2017, 2:12 AM
wjiang added a revision to T12667: Let default parameters linter rule support `...` in variadic function: D17825: Let default parameters linter rule support `...` in variadic function.
May 4 2017, 2:12 AM · Feature Request
wjiang created T12667: Let default parameters linter rule support `...` in variadic function.
May 4 2017, 2:10 AM · Feature Request
wjiang updated the diff for D17783: Improve `ArcanistLinterStandardTestCase`.
  • Minor
May 4 2017, 12:54 AM
wjiang updated the diff for D17783: Improve `ArcanistLinterStandardTestCase`.
  • Add applyStandard
May 4 2017, 12:52 AM

Apr 24 2017

wjiang updated the diff for D17783: Improve `ArcanistLinterStandardTestCase`.

Add final

Apr 24 2017, 1:10 AM
wjiang updated the test plan for D17783: Improve `ArcanistLinterStandardTestCase`.
Apr 24 2017, 1:05 AM
wjiang created D17783: Improve `ArcanistLinterStandardTestCase`.
Apr 24 2017, 1:04 AM
wjiang added a revision to T12631: Improve `ArcanistLinterStandardTestCase`: D17783: Improve `ArcanistLinterStandardTestCase`.
Apr 24 2017, 1:04 AM · Feature Request
wjiang created T12631: Improve `ArcanistLinterStandardTestCase`.
Apr 24 2017, 1:03 AM · Feature Request

Apr 20 2017

wjiang added a comment to T12601: Set default arguments of `ArcanistWorkflow`.

The only behavior of --lintall is to make warnings act like errors. Just raise everything at error severity to achieve the same thing without patching anything.

Apr 20 2017, 1:29 AM · Feature Request
wjiang added a comment to T12601: Set default arguments of `ArcanistWorkflow`.

You are probably raising messages at "warning" severity, but want to raise them at "error" severity. See, e.g., here for a description:

T4287#47494

Apr 20 2017, 1:13 AM · Feature Request
wjiang created D17743: Add `setArgument` to `ArcanistWorkflow`.
Apr 20 2017, 1:01 AM
wjiang added a revision to T12601: Set default arguments of `ArcanistWorkflow`: D17743: Add `setArgument` to `ArcanistWorkflow`.
Apr 20 2017, 1:01 AM · Feature Request
wjiang updated subscribers of T12601: Set default arguments of `ArcanistWorkflow`.
Apr 20 2017, 12:57 AM · Feature Request
wjiang created T12601: Set default arguments of `ArcanistWorkflow`.
Apr 20 2017, 12:57 AM · Feature Request

Dec 11 2016

wjiang added a comment to D10728: Allow `arc liberate` to handle traits and namespaces.

Is this diff still in progress ?

Dec 11 2016, 11:15 PM

Dec 1 2016

wjiang updated the diff for D16967: Let PhutilTypeLexer support qualified names.
  • fix tests
Dec 1 2016, 1:48 AM
wjiang updated the diff for D16967: Let PhutilTypeLexer support qualified names.
  • Add more tests and fix regex
Dec 1 2016, 1:46 AM
wjiang added a revision to T11933: Let `PhutilTypeLexer` support PHP style qualified names: D16967: Let PhutilTypeLexer support qualified names.
Dec 1 2016, 1:06 AM · libphutil, Feature Request
wjiang updated D16967: Let PhutilTypeLexer support qualified names.
Dec 1 2016, 1:06 AM
wjiang added a reviewer for D16967: Let PhutilTypeLexer support qualified names: joshuaspence.
Dec 1 2016, 1:05 AM
wjiang updated subscribers of T11933: Let `PhutilTypeLexer` support PHP style qualified names.
Dec 1 2016, 1:02 AM · libphutil, Feature Request
wjiang created T11933: Let `PhutilTypeLexer` support PHP style qualified names.
Dec 1 2016, 1:02 AM · libphutil, Feature Request