HomePhabricator

Allow `buildFutures` and `resolveFutures` to be overridden

Authored by joshuaspence on Tue, May 14, 11:09 PM.

Description

Allow buildFutures and resolveFutures to be overridden

Summary:
I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see ArcanistDockerContainerLinterProxy from flarc). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan: N/A

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19730

Details

Committed
joshuaspenceTue, May 14, 11:10 PM
Pushed
joshuaspenceTue, May 14, 11:10 PM
Reviewer
Blessed Reviewers
Parents
rARCfceac878f112: Allow `setCustomSeverityRules` to be overridden in subclasses
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22798
Build 31274: Run Core Tests