Page MenuHomePhabricator

Remove unnecessary "," from Pylint version regex
ClosedPublic

Authored by epriestley on May 8 2019, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:23 PM
Unknown Object (File)
May 13 2025, 7:34 PM
Unknown Object (File)
May 7 2025, 8:12 PM
Unknown Object (File)
May 5 2025, 5:53 PM
Unknown Object (File)
Apr 19 2025, 2:42 PM
Unknown Object (File)
Apr 15 2025, 10:13 PM
Unknown Object (File)
Apr 14 2025, 7:43 AM
Unknown Object (File)
Apr 12 2025, 6:13 AM
Subscribers
None

Details

Summary

See PHI1238. This "," in the regex can only make the lint binding fail if there is no "," in the version output string. In modern versions of Pylint, there is (apparently) no comma in the version string. Remove it.

See also https://discourse.phabricator-community.org/t/arcanistpylintlinter-version-regex-issue/2688

Test Plan
$ pip install pylint
Traceback (most recent call last):
  File "/Users/epriestley/Library/Python/2.7/bin/pip", line 6, in <module>
    from pip._internal import main
ImportError: No module named pip._internal

¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable