Page MenuHomePhabricator

Remove unnecessary "," from Pylint version regex
ClosedPublic

Authored by epriestley on May 8 2019, 5:21 PM.

Details

Summary

See PHI1238. This "," in the regex can only make the lint binding fail if there is no "," in the version output string. In modern versions of Pylint, there is (apparently) no comma in the version string. Remove it.

See also https://discourse.phabricator-community.org/t/arcanistpylintlinter-version-regex-issue/2688

Test Plan
$ pip install pylint
Traceback (most recent call last):
  File "/Users/epriestley/Library/Python/2.7/bin/pip", line 6, in <module>
    from pip._internal import main
ImportError: No module named pip._internal

¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 8 2019, 5:21 PM
epriestley requested review of this revision.May 8 2019, 5:22 PM
joshuaspence accepted this revision.May 14 2019, 12:40 AM
This revision is now accepted and ready to land.May 14 2019, 12:40 AM
This revision was automatically updated to reflect the committed changes.