Page MenuHomePhabricator

Remove unnecessary "," from Pylint version regex
ClosedPublic

Authored by epriestley on May 8 2019, 5:21 PM.
Tags
None
Referenced Files
F14400700: D20505.diff
Sun, Dec 22, 8:18 PM
Unknown Object (File)
Sat, Dec 14, 7:44 AM
Unknown Object (File)
Fri, Dec 13, 4:52 AM
Unknown Object (File)
Fri, Dec 13, 4:52 AM
Unknown Object (File)
Fri, Dec 13, 4:52 AM
Unknown Object (File)
Sat, Dec 7, 4:30 AM
Unknown Object (File)
Sat, Nov 30, 3:55 AM
Unknown Object (File)
Sun, Nov 24, 4:43 PM
Subscribers
None

Details

Summary

See PHI1238. This "," in the regex can only make the lint binding fail if there is no "," in the version output string. In modern versions of Pylint, there is (apparently) no comma in the version string. Remove it.

See also https://discourse.phabricator-community.org/t/arcanistpylintlinter-version-regex-issue/2688

Test Plan
$ pip install pylint
Traceback (most recent call last):
  File "/Users/epriestley/Library/Python/2.7/bin/pip", line 6, in <module>
    from pip._internal import main
ImportError: No module named pip._internal

¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable