Page MenuHomePhabricator

Make all comments quotable
AbandonedPublic

Authored by joshuaspence on Nov 5 2015, 8:09 PM.
Tags
None
Referenced Files
F13087343: D14416.diff
Thu, Apr 25, 12:56 AM
Unknown Object (File)
Fri, Apr 19, 2:22 AM
Unknown Object (File)
Fri, Apr 19, 2:22 AM
Unknown Object (File)
Fri, Apr 19, 2:22 AM
Unknown Object (File)
Thu, Apr 11, 8:42 AM
Unknown Object (File)
Thu, Apr 11, 3:42 AM
Unknown Object (File)
Sat, Mar 30, 5:24 AM
Unknown Object (File)
Fri, Mar 29, 2:35 PM
Subscribers

Details

Summary

Fixes T9077. This is a bit messy at the moment and I'm happy to do some tidying up / refactoring, but it seems to work.

Test Plan

Quoted comments in all affected applications.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8646
Build 10013: Run Core Tests
Build 10012: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Make all comments quotable.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

For the refs, maybe just let the code render a neutral string if no ref is present? e.g.

(With Ref) In Txxx#qqqq, epriestley wrote:
(Without Ref) Previously, epriestley wrote:

We lose the link to the comment, but that seems like a small loss for badges/macros.

src/applications/paste/controller/PhabricatorPasteViewController.php
70

First half of this could be monogram, too.

joshuaspence edited edge metadata.

More applications

epriestley edited edge metadata.

WIP

This revision now requires changes to proceed.Nov 8 2015, 2:24 PM

Not actively working on this.