Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6888: Extending revert edges
T1751: Consider ways to improve revert handling

Summary

Ref T1751. Extends revert edges by adding new edge types:

DifferentialRevisionRevertedByCommitEdgeType
DiffusionCommitRevertsRevisionEdgeType
DiffusionCommitRevertsTasksEdgeType
ManiphestTaskRevertedByCommitEdgeType

This means that when a commit is reverted, an edge (and transaction) is created on any tasks/revisions which are associated with the reverted commit(s).

Test Plan

Reverted a commit which contained Ref Tx and Fixes Ty and also mentioned Tz. Saw reverting edges created for Tx and Ty.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php:169	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 7399
Build 7838: [Placeholder Plan] Wait for 30 Seconds
Build 7837: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 30332.Apr 30 2015, 9:56 PM

joshuaspence retitled this revision from to Extend revert edges.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added tasks: T1751: Consider ways to improve revert handling, T6888: Extending revert edges.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 9:56 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Seems to work from some initial testing

Hmm... this doesn't work initially, but does work when I run ./bin/repository reparse.

joshuaspence updated this object.May 1 2015, 1:31 PM

Not quite workign

Working now

joshuaspence updated this object.May 2 2015, 4:15 AM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

bump

bump... any love for this?

eadler added a subscriber: eadler.Jul 3 2015, 7:55 PM

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptJul 26 2015, 11:47 AM

One thing that would be nice is to disable the "mention" for reverts:

Not actively working on this.

This may mostly have been covered by D20469, although that change does not extend to reverting/reopening tasks.

Extend revert edges
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 33148

src/__phutil_library_map__.php

src/applications/differential/edge/DifferentialRevisionRevertedByCommitEdgeType.php

src/applications/diffusion/edge/DiffusionCommitRevertsRevisionEdgeType.php

src/applications/diffusion/edge/DiffusionCommitRevertsTasksEdgeType.php

src/applications/maniphest/edge/ManiphestTaskRevertedByCommitEdgeType.php

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Extend revert edgesAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33148

src/__phutil_library_map__.php

src/applications/differential/edge/DifferentialRevisionRevertedByCommitEdgeType.php

src/applications/diffusion/edge/DiffusionCommitRevertsRevisionEdgeType.php

src/applications/diffusion/edge/DiffusionCommitRevertsTasksEdgeType.php

src/applications/maniphest/edge/ManiphestTaskRevertedByCommitEdgeType.php

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Extend revert edges
AbandonedPublic
Actions

Revision Contents
Changeset List