Page MenuHomePhabricator

Extend revert edges
AbandonedPublic

Authored by joshuaspence on Apr 30 2015, 9:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 4:49 PM
Unknown Object (File)
Sat, Mar 16, 6:32 AM
Unknown Object (File)
Sun, Mar 10, 11:54 AM
Unknown Object (File)
Thu, Feb 29, 10:50 PM
Unknown Object (File)
Feb 21 2024, 4:11 AM
Unknown Object (File)
Feb 8 2024, 4:43 PM
Unknown Object (File)
Feb 7 2024, 7:04 PM
Unknown Object (File)
Feb 3 2024, 3:34 AM

Details

Summary

Ref T1751. Extends revert edges by adding new edge types:

  • DifferentialRevisionRevertedByCommitEdgeType
  • DiffusionCommitRevertsRevisionEdgeType
  • DiffusionCommitRevertsTasksEdgeType
  • ManiphestTaskRevertedByCommitEdgeType

This means that when a commit is reverted, an edge (and transaction) is created on any tasks/revisions which are associated with the reverted commit(s).

Test Plan

Reverted a commit which contained Ref Tx and Fixes Ty and also mentioned Tz. Saw reverting edges created for Tx and Ty.

Diff Detail

Event Timeline

joshuaspence retitled this revision from to Extend revert edges.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.

Seems to work from some initial testing

Hmm... this doesn't work initially, but does work when I run ./bin/repository reparse.

joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

One thing that would be nice is to disable the "mention" for reverts:

ment.png (77×1 px, 19 KB)

Not actively working on this.

This may mostly have been covered by D20469, although that change does not extend to reverting/reopening tasks.