Differential D11504

Add a linter rule for PHP indentation
AbandonedPublic
Actions

Authored by joshuaspence on Jan 26 2015, 10:12 AM.

Tags

None

Referenced Files

	F14047756: D11504.id27759.diff
	Thu, Nov 14, 5:05 AM

	F14047697: D11504.id27664.diff
	Thu, Nov 14, 4:57 AM

	F14047696: D11504.id31635.diff
	Thu, Nov 14, 4:56 AM

	F14047693: D11504.id28041.diff
	Thu, Nov 14, 4:56 AM

	F14047692: D11504.id30205.diff
	Thu, Nov 14, 4:56 AM

	F14047319: D11504.id.diff
	Thu, Nov 14, 3:30 AM

	F14047282: D11504.id27758.diff
	Thu, Nov 14, 3:19 AM

	F14047269: D11504.diff
	Thu, Nov 14, 3:14 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

WIP. Depends on D12295.

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/lint/linter/xhpast/rules/ArcanistIndentationXHPASTLinterRule.php:62	TXT3	Line Too Long

Unit

Test Failures

Build Status

Buildable 6433
Build 6455: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,095 ms	ArcanistXHPASTLinterTestCase::testLinter
	1,181 ms	ArcanistCSSLintLinterTestCase::testLinter
	84 ms	ArcanistCSSLintLinterTestCase::testVersion
	11 ms	ArcanistChmodLinterTestCase::testLinter
	343 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 44 Passed · 9 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 27664.Jan 26 2015, 10:12 AM

joshuaspence retitled this revision from to Add a linter rule for PHP indentation.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 26 2015, 10:12 AM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence mentioned this in D10440: Add an XHPAST linter rule to ensure that only one statement exists per line.Jan 26 2015, 10:13 AM

Just pushing this out of my queue for now, I'm excited about it if you can make it work.

I'm wildly amused by this diff getting flagged by itself.

This revision now requires changes to proceed.Jan 26 2015, 3:14 PM

Somewhat working

Herald added a subscriber: Korvin. · View Herald TranscriptJan 28 2015, 11:15 AM

Somewhat working

Further work, still WIP

joshuaspence mentioned this in D12295: Add a method to get the indentation for an XHPASTNode.Apr 5 2015, 12:15 PM

joshuaspence mentioned this in rPHUd30d314dc8eb: Add a method to get the indentation for an XHPASTNode.Apr 6 2015, 9:44 PM

Rebase, still not working

joshuaspence updated this object.Jun 1 2015, 9:08 PM

joshuaspence added a parent revision: D12295: Add a method to get the indentation for an XHPASTNode.

Further work, seems to work reasonably well but still needs work

Not actively working on this.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

lint/

linter/

__tests__/

xhpast/

call-time-pass-by-reference.lint-test

6 lines

indentation.lint-test

26 lines

php54-features.lint-test

4 lines

xhpast/

rules/

ArcanistIndentationXHPASTLinterRule.php

84 lines

Diff 31635

src/__phutil_library_map__.php

Loading...

src/lint/linter/tests/xhpast/call-time-pass-by-reference.lint-test

Loading...

src/lint/linter/tests/xhpast/indentation.lint-test

Loading...

src/lint/linter/tests/xhpast/php54-features.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistIndentationXHPASTLinterRule.php

Loading...