Page MenuHomePhabricator

Fix class attribute node in anonymous class
Needs ReviewPublic

Authored by wjiang on Oct 9 2018, 1:39 AM.

Details

Summary

Ref T4334. The class attribute node of an anonymous class should be n_EMPTY.

Test Plan

Tested with phabricator xhpast view

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint WarningsExcuse: dd
SeverityLocationCodeMessage
Warningsupport/xhpast/xhpast.cpp:0Cppchecktoomanyconfigs
Unit
Unit Tests OK
Build Status
Buildable 21005
Build 28534: arc lint + arc unit

Event Timeline

wjiang created this revision.Oct 9 2018, 1:39 AM
wjiang requested review of this revision.Oct 9 2018, 1:39 AM
wjiang edited the test plan for this revision. (Show Details)Oct 9 2018, 1:39 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

wjiang added a comment.Oct 9 2018, 1:47 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Hmm.. I doubt that'll happen as anonymous class can never be extended.

joshuaspence accepted this revision.Oct 9 2018, 3:31 AM

@epriestley, would you mind taking a look at this diff?