Page MenuHomePhabricator

Fix class attribute node in anonymous class
ClosedPublic

Authored by wjiang on Oct 9 2018, 1:39 AM.

Details

Summary

Ref T4334. The class attribute node of an anonymous class should be n_EMPTY.

Test Plan

Tested with phabricator xhpast view

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wjiang created this revision.Oct 9 2018, 1:39 AM
wjiang requested review of this revision.Oct 9 2018, 1:39 AM
wjiang edited the test plan for this revision. (Show Details)Oct 9 2018, 1:39 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

wjiang added a comment.Oct 9 2018, 1:47 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Hmm.. I doubt that'll happen as anonymous class can never be extended.

joshuaspence accepted this revision.Oct 9 2018, 3:31 AM

@epriestley, would you mind taking a look at this diff?

epriestley accepted this revision.Tue, May 14, 2:21 PM
This revision is now accepted and ready to land.Tue, May 14, 2:21 PM
This revision was landed with ongoing or failed builds.Wed, May 15, 12:55 AM
This revision was automatically updated to reflect the committed changes.