Page MenuHomePhabricator

Fix class attribute node in anonymous class
ClosedPublic

Authored by wjiang on Oct 9 2018, 1:39 AM.
Tags
None
Referenced Files
F18739739: D19740.diff
Wed, Oct 1, 10:42 PM
F18738016: D19740.id48926.diff
Wed, Oct 1, 1:44 PM
F18612976: D19740.diff
Sun, Sep 14, 10:28 AM
F18598407: D19740.diff
Sat, Sep 13, 4:57 AM
F18587533: D19740.id48926.diff
Thu, Sep 11, 9:42 PM
F18586883: D19740.id48926.diff
Thu, Sep 11, 7:56 PM
F18586859: D19740.id.diff
Thu, Sep 11, 7:53 PM
F18534339: D19740.id48926.diff
Sep 7 2025, 11:25 AM

Details

Summary

Ref T4334. The class attribute node of an anonymous class should be n_EMPTY.

Test Plan

Tested with phabricator xhpast view

1.png (324×475 px, 14 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wjiang requested review of this revision.Oct 9 2018, 1:39 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Hmm.. I doubt that'll happen as anonymous class can never be extended.

@epriestley, would you mind taking a look at this diff?

This revision is now accepted and ready to land.May 14 2019, 2:21 PM
This revision was landed with ongoing or failed builds.May 15 2019, 12:55 AM
This revision was automatically updated to reflect the committed changes.