Page MenuHomePhabricator

Fix class attribute node in anonymous class
ClosedPublic

Authored by wjiang on Oct 9 2018, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Thu, Apr 11, 4:09 AM
Unknown Object (File)
Fri, Apr 5, 9:37 AM
Unknown Object (File)
Fri, Apr 5, 9:15 AM
Unknown Object (File)
Fri, Mar 29, 12:39 AM
Unknown Object (File)
Sat, Mar 16, 10:32 AM
Unknown Object (File)
Mar 1 2024, 4:11 AM
Unknown Object (File)
Feb 21 2024, 12:08 PM

Details

Summary

Ref T4334. The class attribute node of an anonymous class should be n_EMPTY.

Test Plan

Tested with phabricator xhpast view

1.png (324×475 px, 14 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wjiang requested review of this revision.Oct 9 2018, 1:39 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Hmm.. I doubt that'll happen as anonymous class can never be extended.

@epriestley, would you mind taking a look at this diff?

This revision is now accepted and ready to land.May 14 2019, 2:21 PM
This revision was landed with ongoing or failed builds.May 15 2019, 12:55 AM
This revision was automatically updated to reflect the committed changes.