Page MenuHomePhabricator
Differential D20555

Add a hook method that is called before `ArcanistLinter::getLinterConfigurationOptions`
Needs ReviewPublic
Actions

Authored by joshuaspence on May 24 2019, 4:45 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a third-party linter which allows different configuration options depending on the value of one specific configuration option. This diff adds a ArcanistLinter::willSetLinterConfiguration hook method that is called before ArcanistLinter::getLinterConfigurationOptions to facilitate this type of functionality.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
lint6
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22911
Build 31431: Run Core Tests
Build 31430: arc lint + arc unit

Event Timeline

joshuaspence created this revision.May 24 2019, 4:45 AM
joshuaspence requested review of this revision.May 24 2019, 4:45 AM
joshuaspence added inline comments.May 26 2019, 10:19 PM
src/lint/linter/ArcanistLinter.php
490

Alternative method names:

  • willSetLinterConfigurationOptions
  • willSetLinterConfigurationValues

Revision Contents
Changeset List

PathCoverage (All)Coverage (Touched)Packages
Msrc/lint/engine/ArcanistConfigurationDrivenLintEngine.php (1 line)0%
Loading...
Msrc/lint/linter/ArcanistLinter.php (4 lines)49%
Loading...

Diff 49038

View Options

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistLinter.php

Loading...
Phabricator · Built by Phacility