Page MenuHomePhabricator
Differential D15133

Allow objects implementing `ArrayAccess` to the passed to `idx`
AbandonedPublic
Actions

Authored by joshuaspence on Jan 28 2016, 11:32 PM.
Tags
None
Referenced Files
F15427231: D15133.diff
Sun, Mar 23, 1:23 PM
F15414156: D15133.diff
Wed, Mar 19, 11:16 PM
F15394944: D15133.diff
Sun, Mar 16, 2:33 AM
F15383018: D15133.diff
Fri, Mar 14, 3:16 PM
F15375574: D15133.diff
Wed, Mar 12, 11:34 PM
F15370244: D15133.id36537.diff
Mar 12 2025, 9:30 AM
F15335842: D15133.diff
Mar 8 2025, 5:38 PM
Unknown Object (File)
Feb 26 2025, 5:10 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This allows idx to work with CaseInsensitiveArray, for example.

Test Plan

Added a test case.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1194XHP45PHP Compatibility
Errorsrc/utils/utils.php:1194XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 10376
Build 12659: Run Core Tests
Build 12658: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 36537.Jan 28 2016, 11:32 PM
joshuaspence retitled this revision from to Allow objects implementing `ArrayAccess` to the passed to `idx`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2016, 11:32 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley mentioned this in T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.Aug 19 2016, 5:36 PM
joshuaspence abandoned this revision.May 17 2019, 1:52 AM

Not actively working on this.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
utils/
__tests__/
3 lines99%
Loading...
9 lines71%
Loading...

Diff 36537

View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility