Page MenuHomePhabricator

Allow `buildFutures` and `resolveFutures` to be overridden
ClosedPublic

Authored by joshuaspence on Oct 4 2018, 12:02 AM.
Tags
None
Referenced Files
F13236520: D19730.diff
Tue, May 21, 9:58 AM
F13217976: D19730.diff
Sat, May 18, 9:12 AM
F13206689: D19730.diff
Wed, May 15, 3:42 PM
F13193023: D19730.id47147.diff
Sun, May 12, 11:39 AM
F13192815: D19730.id48916.diff
Sun, May 12, 9:45 AM
F13192740: D19730.id48925.diff
Sun, May 12, 9:32 AM
F13192513: D19730.id.diff
Sun, May 12, 8:24 AM
F13192022: D19730.id48916.diff
Sun, May 12, 4:02 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 4 2018, 12:02 AM
Harbormaster failed remote builds in B20987: Diff 47147!
This revision is now accepted and ready to land.May 14 2019, 2:21 PM