Page MenuHomePhabricator

Allow `buildFutures` and `resolveFutures` to be overridden
ClosedPublic

Authored by joshuaspence on Oct 4 2018, 12:02 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see ArcanistDockerContainerLinterProxy from flarc). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence created this revision.Oct 4 2018, 12:02 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 4 2018, 12:02 AM
Harbormaster failed remote builds in B20987: Diff 47147!
joshuaspence edited the summary of this revision. (Show Details)May 14 2019, 12:31 AM
joshuaspence requested review of this revision.May 14 2019, 12:32 AM
epriestley accepted this revision.May 14 2019, 2:21 PM
This revision is now accepted and ready to land.May 14 2019, 2:21 PM

Thanks for the reviews :)