Page MenuHomePhabricator

Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic

Authored by joshuaspence on Mon, May 13, 4:18 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see ArcanistDockerContainerLinterProxy from flarc). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence created this revision.Mon, May 13, 4:18 AM
joshuaspence requested review of this revision.Mon, May 13, 4:19 AM

Remove a TODO comment that is no longer relevant

joshuaspence edited the summary of this revision. (Show Details)Tue, May 14, 12:30 AM
epriestley accepted this revision.Tue, May 14, 2:10 PM
This revision is now accepted and ready to land.Tue, May 14, 2:10 PM