Page MenuHomePhabricator

Allow `setCustomSeverityRules` to be overridden in subclasses

Authored by joshuaspence on May 13 2019, 4:18 AM.


Group Reviewers
Blessed Reviewers

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[ |ArcanistDockerContainerLinterProxy]] from [[ | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan


Diff Detail

rARC Arcanist
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence created this revision.May 13 2019, 4:18 AM
joshuaspence requested review of this revision.May 13 2019, 4:19 AM

Remove a TODO comment that is no longer relevant

joshuaspence edited the summary of this revision. (Show Details)May 14 2019, 12:30 AM
epriestley accepted this revision.May 14 2019, 2:10 PM
This revision is now accepted and ready to land.May 14 2019, 2:10 PM