Page MenuHomePhabricator

Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 29, 8:04 PM
Unknown Object (File)
Mon, Jun 29, 8:04 PM
Unknown Object (File)
Thu, Jun 25, 8:14 AM
Unknown Object (File)
Mon, Jun 22, 8:49 PM
Unknown Object (File)
Thu, Jun 18, 1:03 AM
Unknown Object (File)
Mar 9 2026, 6:28 PM
Unknown Object (File)
Mar 8 2026, 9:48 AM
Unknown Object (File)
Mar 6 2026, 10:53 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove a TODO comment that is no longer relevant

This revision is now accepted and ready to land.May 14 2019, 2:10 PM