Page MenuHomePhabricator

Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:18 AM.
Tags
None
Referenced Files
F18818447: D20514.diff
Wed, Oct 22, 12:24 AM
F18772797: D20514.id48924.diff
Thu, Oct 9, 4:49 AM
F18769500: D20514.id48915.diff
Wed, Oct 8, 7:53 AM
F18741147: D20514.id.diff
Oct 2 2025, 8:54 AM
F18739278: D20514.diff
Oct 1 2025, 8:42 PM
F18653584: D20514.diff
Sep 21 2025, 2:25 PM
F18653472: D20514.diff
Sep 21 2025, 1:49 PM
F18653470: D20514.diff
Sep 21 2025, 1:47 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove a TODO comment that is no longer relevant

This revision is now accepted and ready to land.May 14 2019, 2:10 PM