Page MenuHomePhabricator
Feed All Stories

May 20 2019

epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 20 2019, 12:56 PM · Plans
epriestley added revisions to T11229: Quotes breaks headings by default: D20327: In remarkup, strip one leading space from each line in a quoted block if possible, D20393: Make the "Reply" and "Quote" Remarkup rules more similar.
May 20 2019, 12:03 PM · Remarkup, Bug Report
epriestley added a task to D20393: Make the "Reply" and "Quote" Remarkup rules more similar: T11229: Quotes breaks headings by default.
May 20 2019, 12:03 PM
epriestley added a task to D20327: In remarkup, strip one leading space from each line in a quoted block if possible: T11229: Quotes breaks headings by default.
May 20 2019, 12:03 PM
asherkin updated the summary of D19681: Fix arc land on odd/modern git-svn checkouts.
May 20 2019, 11:56 AM
asherkin added a revision to T13293: `arc land` using git-svn fails in certain configurations: D19681: Fix arc land on odd/modern git-svn checkouts.
May 20 2019, 11:56 AM · Subversion, Git, Arcanist
asherkin created T13293: `arc land` using git-svn fails in certain configurations.
May 20 2019, 11:56 AM · Subversion, Git, Arcanist
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 20 2019, 11:47 AM · Diffusion
joshuaspence updated the diff for D20526: Make it easier to parse external linter versions.

Remove unrelated change

May 20 2019, 2:07 AM
joshuaspence added inline comments to D20526: Make it easier to parse external linter versions.
May 20 2019, 2:05 AM
joshuaspence requested review of D20526: Make it easier to parse external linter versions.
May 20 2019, 1:57 AM
epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 20 2019, 1:36 AM · Plans
epriestley committed rPHUc175590464bd: Improve the performance of large remarkup documents with many complex rules (authored by epriestley).
Improve the performance of large remarkup documents with many complex rules
May 20 2019, 12:24 AM
epriestley closed D20522: Improve the performance of large remarkup documents with many complex rules.
May 20 2019, 12:24 AM

May 19 2019

epriestley committed rP06778ea55032: Separate the "configuration" and "evaluation" phases of chart functions (authored by epriestley).
Separate the "configuration" and "evaluation" phases of chart functions
May 19 2019, 11:55 PM
epriestley closed D20454: Separate the "configuration" and "evaluation" phases of chart functions.
May 19 2019, 11:55 PM
epriestley requested review of D20525: Fix an issue where handles could load with the incorrect viewer when building mail about changes to related objects.
May 19 2019, 11:01 PM
epriestley triaged T13292: Create a "Sounds" application as Normal priority.
May 19 2019, 9:04 PM · Sounds
epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 19 2019, 8:48 PM · Remarkup, Diffusion
epriestley added a comment to D12634: Extend revert edges.

This may mostly have been covered by D20469, although that change does not extend to reverting/reopening tasks.

May 19 2019, 7:43 PM

May 17 2019

epriestley committed rPa76e91ea9ef6: Remove obsolete Dashboard panel methods with no callsites (authored by epriestley).
Remove obsolete Dashboard panel methods with no callsites
May 17 2019, 7:09 PM
epriestley closed D20484: Remove obsolete Dashboard panel methods with no callsites.
May 17 2019, 7:09 PM
epriestley committed rP167f06d3eb70: Label transaction groups with a "group ID" so Herald can reconstruct them… (authored by epriestley).
Label transaction groups with a "group ID" so Herald can reconstruct them…
May 17 2019, 7:07 PM
epriestley closed D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully.
May 17 2019, 7:07 PM
amckinley accepted D20454: Separate the "configuration" and "evaluation" phases of chart functions.
May 17 2019, 4:07 PM
amckinley accepted D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully.
May 17 2019, 3:56 PM
epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 17 2019, 3:13 PM · Remarkup, Diffusion
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
May 17 2019, 2:43 PM · Dashboards
epriestley added a revision to T8033: Inform editor when panels have more restrictive policy than dashboard: D20376: On Dashboards, distinguish between invalid panels and restricted panels.
May 17 2019, 2:36 PM · Dashboards
epriestley added a task to D20376: On Dashboards, distinguish between invalid panels and restricted panels: T8033: Inform editor when panels have more restrictive policy than dashboard.
May 17 2019, 2:36 PM
epriestley added a project to T13285: Service failures in JIRA can cascade into service failures in Phabricator: Doorkeeper.
May 17 2019, 2:24 PM · Doorkeeper
epriestley triaged T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion as Normal priority.
May 17 2019, 2:22 PM · Remarkup, Diffusion
epriestley closed T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Resolved.

This stuff is largely resolved, but survived by a few remaining issues in T13290.

May 17 2019, 2:18 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a parent task for T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily: T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".
May 17 2019, 2:17 PM · Restricted Project, Prioritized, Differential
epriestley added a parent task for T7333: Empty commits get same revision as parent: T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".
May 17 2019, 2:17 PM · Differential
epriestley added subtasks for T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily, T7333: Empty commits get same revision as parent.
May 17 2019, 2:17 PM · Diffusion, Differential
epriestley added a project to T7333: Empty commits get same revision as parent: Differential.
May 17 2019, 2:17 PM · Differential
epriestley triaged T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" as Normal priority.
May 17 2019, 2:15 PM · Diffusion, Differential
joshuaspence abandoned D11773: [Draft] Convert `ArcanistScriptAndRegexLinter` to `ArcanistExternalLinter`.

Not actively working on this.

May 17 2019, 2:24 AM
joshuaspence abandoned D10741: Added SCSS-Lint linter.

Moving this to [[https://github.com/freelancer/flarc | flarc]].

May 17 2019, 2:22 AM
joshuaspence abandoned D11657: Add a ShellCheck linter.

Moving this to [[https://github.com/freelancer/flarc | flarc]].

May 17 2019, 2:20 AM
joshuaspence abandoned D15133: Allow objects implementing `ArrayAccess` to the passed to `idx`.

Not actively working on this.

May 17 2019, 1:52 AM
joshuaspence abandoned D14936: Convert passphrase to edit engine.

Not actively working on this.

May 17 2019, 1:52 AM
joshuaspence abandoned D14655: Add an ID field to `PhabricatorBotTarget`.

This code is gone.

May 17 2019, 1:51 AM
joshuaspence abandoned D14616: Consolidate two linter rules.

Not actively working on this.

May 17 2019, 1:51 AM
joshuaspence abandoned D14482: Improve FontAwesome icons.

Not actively working on this.

May 17 2019, 1:51 AM
joshuaspence abandoned D14474: Improve a bunch of translation strings.

Not actively working on this.

May 17 2019, 1:50 AM
joshuaspence abandoned D14460: Provide more context to naming hook linter.

Not actively working on this.

May 17 2019, 1:15 AM
joshuaspence abandoned D14416: Make all comments quotable.

Not actively working on this.

May 17 2019, 1:13 AM
joshuaspence abandoned D14074: Add escaping for Checkstyle output.

Not actively working on this.

May 17 2019, 1:13 AM
joshuaspence abandoned D13373: Separate interfaces in library maps.

Not actively working on this.

May 17 2019, 1:10 AM
joshuaspence abandoned D13271: Rename DoorkeeperBridge subclasses.

Not actively working on this.

May 17 2019, 1:10 AM
joshuaspence abandoned D12634: Extend revert edges.

Not actively working on this.

May 17 2019, 1:09 AM
joshuaspence abandoned D11504: Add a linter rule for PHP indentation.

Not actively working on this.

May 17 2019, 1:09 AM

May 16 2019

epriestley claimed T13289: Plans: 2019 Week 21-23 Bonus Content.
May 16 2019, 9:37 PM · Plans
epriestley triaged T13289: Plans: 2019 Week 21-23 Bonus Content as Normal priority.
May 16 2019, 9:37 PM · Plans
epriestley closed T13263: Plans: 2019 Week 11-15 Bonus Content as Resolved.
May 16 2019, 9:35 PM · Plans
epriestley edited the content of 2019 Week 20 (Late May).
May 16 2019, 9:18 PM
epriestley committed rARCa23b58c60534: Merge branch "master" into "experimental". (authored by epriestley).
Merge branch "master" into "experimental".
May 16 2019, 9:12 PM
epriestley edited the content of Changelog.
May 16 2019, 9:01 PM
epriestley edited the content of 2019 Week 17 (Very Late April).
May 16 2019, 9:01 PM
epriestley created 2019 Week 20 (Late May).
May 16 2019, 9:00 PM
epriestley committed rPHU1185300a23d9: (stable) Promote 2019 Week 20 (authored by epriestley).
(stable) Promote 2019 Week 20
May 16 2019, 8:57 PM
epriestley committed rARC26452002a256: (stable) Promote 2019 Week 20 (authored by epriestley).
(stable) Promote 2019 Week 20
May 16 2019, 8:57 PM
epriestley committed rP3337b84073f9: (stable) Promote 2019 Week 20 (authored by epriestley).
(stable) Promote 2019 Week 20
May 16 2019, 8:57 PM
epriestley created 2019 Week 19 (Mid May).
May 16 2019, 8:39 PM
epriestley created 2019 Week 18 (Early May).
May 16 2019, 8:39 PM
epriestley requested review of D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully.
May 16 2019, 8:17 PM
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully.
May 16 2019, 8:16 PM · Herald
epriestley triaged T13288: Add a "Download" / view raw option to code blocks in Remarkup as Low priority.
May 16 2019, 7:52 PM · Remarkup
epriestley committed rP6bff2cee22fc: Improve the performance of tab replacement in common cases (authored by epriestley).
Improve the performance of tab replacement in common cases
May 16 2019, 7:28 PM
epriestley closed D20477: Improve the performance of tab replacement in common cases.
May 16 2019, 7:28 PM
epriestley committed rPc5ecc388a212: Make branch status more clear on Diffusion branches view (authored by epriestley).
Make branch status more clear on Diffusion branches view
May 16 2019, 7:24 PM
epriestley closed D20493: Make branch status more clear on Diffusion branches view.
May 16 2019, 7:24 PM
epriestley committed rPe059997e536d: Expose subscribers transaction data via Conduit "transaction.search" (authored by epriestley).
Expose subscribers transaction data via Conduit "transaction.search"
May 16 2019, 7:19 PM
epriestley closed D20508: Expose subscribers transaction data via Conduit "transaction.search".
May 16 2019, 7:19 PM
epriestley committed rP23bfe0c0f694: Specialize rendering of self-URIs in the form "/X123" (authored by epriestley).
Specialize rendering of self-URIs in the form "/X123"
May 16 2019, 7:16 PM
epriestley closed D20512: Specialize rendering of self-URIs in the form "/X123".
May 16 2019, 7:16 PM
epriestley added inline comments to D20512: Specialize rendering of self-URIs in the form "/X123".
May 16 2019, 6:25 PM
epriestley committed rPHU609b1532f512: Provide an extension point for handling hyperlinks in remarkup in a special way (authored by epriestley).
Provide an extension point for handling hyperlinks in remarkup in a special way
May 16 2019, 6:23 PM
epriestley closed D20511: Provide an extension point for handling hyperlinks in remarkup in a special way.
May 16 2019, 6:23 PM
epriestley committed rP706826bf022f: When a user pastes a Phabricator URI into the search box, redirect to the URI (authored by epriestley).
When a user pastes a Phabricator URI into the search box, redirect to the URI
May 16 2019, 6:20 PM
epriestley closed D20510: When a user pastes a Phabricator URI into the search box, redirect to the URI.
May 16 2019, 6:20 PM
epriestley committed rPf2feb0378f54: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class (authored by epriestley).
Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class
May 16 2019, 6:15 PM
epriestley closed D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.
May 16 2019, 6:14 PM
epriestley added a comment to D20522: Improve the performance of large remarkup documents with many complex rules.

I'll hold this until after the release cut anyway since errors here are unusually dangerous (they can lead to XSS very easily), but I think it would also be hard to get this wrong without breaking a lot of unit tests and UI behavior in fairly obvious ways.

May 16 2019, 6:13 PM
epriestley updated the diff for D20522: Improve the performance of large remarkup documents with many complex rules.
  • Choose less-misleading constants and notations for the examples.
  • Rewrite the example documentation to more clearly follow the new execution flow.
  • Clarify the "child tokens appear first" explanation.
  • Make encountering an invalid token ("01234" or "99999") throw. It should be impossible for invalid tokens to appear anywhere.
  • Make encountering an out-of-order token (for example, token 30 while we're processing token 20) throw. It should be impossible for out-of-order tokens to appear anywhere.
May 16 2019, 6:10 PM
epriestley added inline comments to D20522: Improve the performance of large remarkup documents with many complex rules.
May 16 2019, 6:06 PM
epriestley committed rP4a3481a49384: Enrich "draft", "summary", and "testPlan" transactions from Differential in… (authored by epriestley).
Enrich "draft", "summary", and "testPlan" transactions from Differential in…
May 16 2019, 5:50 PM
epriestley closed D20507: Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search".
May 16 2019, 5:50 PM
amckinley accepted D20522: Improve the performance of large remarkup documents with many complex rules.

I've been staring at this long enough that I can plausibly claim to understand how it works. Put this on the pile of "terrible interview questions that I'm sure someone somewhere is getting asked".

May 16 2019, 5:49 PM
epriestley committed rP18f0f8b029a9: Add support for custom "Wait for Approval" instructions (authored by epriestley).
Add support for custom "Wait for Approval" instructions
May 16 2019, 5:42 PM
epriestley closed D20492: Add support for custom "Wait for Approval" instructions.
May 16 2019, 5:42 PM
epriestley committed rPe5fe4dffe1dc: Add a "Published document changed" rule to Herald for Phriction documents (authored by epriestley).
Add a "Published document changed" rule to Herald for Phriction documents
May 16 2019, 5:41 PM
epriestley closed D20520: Add a "Published document changed" rule to Herald for Phriction documents.
May 16 2019, 5:41 PM
epriestley added a comment to D20507: Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search".

In either case, not an API change, just a nomenclature change.

May 16 2019, 5:35 PM
epriestley added a comment to D20507: Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search".

I only blamed around a little bit, but I'm nearly certain they were named incorrectly from the beginning.

May 16 2019, 5:35 PM
epriestley committed rPbf2f3991d237: When using the Herald test console on a transactional object, guess a… (authored by epriestley).
When using the Herald test console on a transactional object, guess a…
May 16 2019, 5:33 PM
epriestley closed D20519: When using the Herald test console on a transactional object, guess a reasonable set of transactions to simulate.
May 16 2019, 5:33 PM
epriestley added a comment to D20519: When using the Herald test console on a transactional object, guess a reasonable set of transactions to simulate.

Doing this right (or, at least, more right) is probably about 20 lines of code and would make transaction.search a little more useful, so I may just take a stab at it at the end of this series.

May 16 2019, 5:19 PM