Page MenuHomePhabricator

On Dashboards, distinguish between invalid panels and restricted panels
ClosedPublic

Authored by epriestley on Wed, Apr 3, 2:01 PM.

Details

Summary

Depends on D20374. Panels may not be visible if they are restricted (no permission) or if they are invalid (e.g., the panel was deleted).

Render these as two separate states instead of one big combined state.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Apr 3, 2:01 PM
epriestley requested review of this revision.Wed, Apr 3, 2:03 PM
epriestley updated this revision to Diff 48614.Wed, Apr 3, 2:04 PM
  • Use a more conventional spelling of "restricted".
amckinley accepted this revision.Wed, Apr 3, 7:17 PM
This revision is now accepted and ready to land.Wed, Apr 3, 7:17 PM
This revision was automatically updated to reflect the committed changes.