Differential D20376

On Dashboards, distinguish between invalid panels and restricted panels
ClosedPublic
Actions

Authored by epriestley on Apr 3 2019, 2:01 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T8033: Inform editor when panels have more restrictive policy than dashboard

Commits

rP2bd1bb52e48c: On Dashboards, distinguish between invalid panels and restricted panels

Summary

Depends on D20374. Panels may not be visible if they are restricted (no permission) or if they are invalid (e.g., the panel was deleted).

Render these as two separate states instead of one big combined state.

Test Plan

Screen Shot 2019-04-03 at 6.59.43 AM.png (217×777 px, 15 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 3 2019, 2:01 PM

Harbormaster completed remote builds in B22487: Diff 48613.Apr 3 2019, 2:03 PM

epriestley requested review of this revision.Apr 3 2019, 2:03 PM

Use a more conventional spelling of "restricted".

Harbormaster completed remote builds in B22488: Diff 48614.Apr 3 2019, 2:06 PM

epriestley added a child revision: D20377: When a dashboard has inconsistent panel policies: keep doing nothing.Apr 3 2019, 4:26 PM

amckinley accepted this revision.Apr 3 2019, 7:17 PM

This revision is now accepted and ready to land.Apr 3 2019, 7:17 PM

Closed by commit rP2bd1bb52e48c: On Dashboards, distinguish between invalid panels and restricted panels (authored by epriestley). · Explain WhyApr 9 2019, 9:00 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a task: T8033: Inform editor when panels have more restrictive policy than dashboard.May 17 2019, 2:36 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

engine/

PhabricatorDashboardPanelRenderingEngine.php

31 lines

PhabricatorDashboardRenderingEngine.php

11 lines

Diff 48641

View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php