Differential D20376

On Dashboards, distinguish between invalid panels and restricted panels
ClosedPublic
Actions

Authored by epriestley on Wed, Apr 3, 2:01 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rP2bd1bb52e48c: On Dashboards, distinguish between invalid panels and restricted panels

Summary

Depends on D20374. Panels may not be visible if they are restricted (no permission) or if they are invalid (e.g., the panel was deleted).

Render these as two separate states instead of one big combined state.

Test Plan

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Apr 3, 2:01 PM

Harbormaster completed remote builds in B22487: Diff 48613.Wed, Apr 3, 2:03 PM

epriestley requested review of this revision.Wed, Apr 3, 2:03 PM

Use a more conventional spelling of "restricted".

Harbormaster completed remote builds in B22488: Diff 48614.Wed, Apr 3, 2:06 PM

epriestley added a child revision: D20377: When a dashboard has inconsistent panel policies: keep doing nothing.Wed, Apr 3, 4:26 PM

amckinley accepted this revision.Wed, Apr 3, 7:17 PM

This revision is now accepted and ready to land.Wed, Apr 3, 7:17 PM

Closed by commit rP2bd1bb52e48c: On Dashboards, distinguish between invalid panels and restricted panels (authored by epriestley). · Explain WhyTue, Apr 9, 9:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php (31 lines)
M			src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php (11 lines)

Diff 48641

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...