Diffusion Arcanist 26452002a256

(stable) Promote 2019 Week 20
Audit Required26452002a256
Actions

Description

(stable) Promote 2019 Week 20

Details

Group Auditors

Provenance

epriestley	Authored on May 16 2019, 8:57 PM
epriestley	Pushed on May 16 2019, 8:57 PM

Parents

rARC82445bb60534: Let lint rules support anonymous classes
rARC4d22e0f89f10: (stable) Promote 2019 Week 10

Branches

Unknown

Tags

Unknown

Build Status

Buildable 22820
Build 31301: Run Core Tests

Event Timeline

epriestley committed rARC26452002a256: (stable) Promote 2019 Week 20 (authored by epriestley).May 16 2019, 8:57 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptMay 16 2019, 8:57 PM

This commit now requires audit.May 16 2019, 8:57 PM

Harbormaster completed building B22820: rARC26452002a256: (stable) Promote 2019 Week 20.May 16 2019, 8:58 PM

Merged Changes

82445bb60534 Let lint rules support anonymous classes
Author
wjiang
Browse Repository
Passed
No Audits
6a8e76db329e Allow `buildFutures` and `resolveFutures` to be overridden
Author
joshuaspence
Browse Repository
Passed
No Audits
fceac878f112 Allow `setCustomSeverityRules` to be overridden in subclasses
Author
joshuaspence
Browse Repository
Passed
No Audits
4f583dded366 Call `$linter->setEngine` in linter tests
Author
joshuaspence
Browse Repository
Passed
No Audits
9ccbbee33675 Fix a potential double-prompt in "arc land" when landing with ongoing builds
Author
epriestley
Browse Repository
Passed
No Audits
b61e890a0ca8 Remove unnecessary "," from Pylint version regex
Author
epriestley
Browse Repository
Passed
No Audits

Changes (13)

Path

Size

src/

lint/

linter/

ArcanistExternalLinter.php

ArcanistLinter.php

ArcanistPyLintLinter.php

__tests__/

ArcanistLinterTestCase.php

xhpast/

rules/

ArcanistClassNameLiteralXHPASTLinterRule.php

ArcanistConstructorParenthesesXHPASTLinterRule.php

ArcanistSelfClassReferenceXHPASTLinterRule.php

ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

__tests__/

class-name-literal/

class-name-literal.lint-test

constructor-parentheses/

constructor-parentheses.lint-test

self-class-reference/

self-class-references.lint-test

unnecessary-final-modifier/

unnecessary-final-modifier.lint-test

workflow/

ArcanistLandWorkflow.php

rARC26452002a256

View Options

src/lint/linter/ArcanistExternalLinter.php

View Options

src/lint/linter/ArcanistLinter.php

View Options

src/lint/linter/ArcanistPyLintLinter.php

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

View Options

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/class-name-literal/class-name-literal.lint-test

View Options

src/lint/linter/xhpast/rules/tests/constructor-parentheses/constructor-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

View Options

src/lint/linter/xhpast/rules/tests/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

View Options

src/workflow/ArcanistLandWorkflow.php

(stable) Promote 2019 Week 20Audit Required26452002a256Actions

Description

Details

Event Timeline

Merged Changes

Changes (13)

rARC26452002a256

src/lint/linter/ArcanistExternalLinter.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/ArcanistPyLintLinter.php

src/lint/linter/__tests__/ArcanistLinterTestCase.php

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/class-name-literal/class-name-literal.lint-test

src/lint/linter/xhpast/rules/__tests__/constructor-parentheses/constructor-parentheses.lint-test

src/lint/linter/xhpast/rules/__tests__/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/__tests__/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

src/workflow/ArcanistLandWorkflow.php

(stable) Promote 2019 Week 20
Audit Required26452002a256
Actions

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/xhpast/rules/tests/class-name-literal/class-name-literal.lint-test

src/lint/linter/xhpast/rules/tests/constructor-parentheses/constructor-parentheses.lint-test

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-final-modifier/unnecessary-final-modifier.lint-test