Page MenuHomePhabricator

Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Open, NormalPublic

Description

PHI1165 raises an issue where multiple commits which close a revision may act at the same time, racing in the transaction log. This probably needs a global lock.

PHI1159 would like build failures exposed to Herald to trigger audits. See also PHI953. See also PHI901.

PHI1118 is running into an issue with "Audit unreviewed commits" apparently not working correctly.

In PHI1008, when commit X reverts commit Y, we don't write a revert edge between X and revisions associated with Y. We should.