• Flip the rules into "Revision has build warning", which is an attempt to express "Revision has failed or ongoing builds which 'arc land' would raise a warning about" more concisely.

After some thought, I'm going to adjust this rule slightly into "Revision has ongoing or failed builds", since I think that's probably more consistent with user expectation and less likely to trip people up.

• Clarify the comment.
• Adjust the cache behavior slightly.

I think the only "fix" for this issue would be to have a rule like "a commit may only be associated with objects that the user who pushed it can see", but this can't realistically be a default rule since it won't work with observed repositories.

Specifically, the attack this comment is describing is this:

The comment is pretty specific to Herald (where $viewer is omnipotent) and loadRevisionForCommit() has other callers where $viewer is legitimate, so I think moving the comment would reduce clarity on the balance. But let me update it a little bit, since it's less clear now than it was before.

For PHP, that's pretty good!

If you min(1, 2, null), you get null.

I think a possible model for the UI is to have some base ChartConfigurationEngine, similar to SearchEngine, which defines a set of fields. Some fields would be common (e.g., all time-series charts can have time controls for domains).

The concrete use cases that are currently filed are:

This is approximately coming into existence and this task no longer serves much of a purpose. See T13083 / T13279 for followups.

This now approximately exists and is no longer of much use as a standalone task. See T13279 and elsewhere for followups.

See followups; this seems to at least get us somewhere.

hmmm

Wow thank you for this. I came across a diff that mixed a lot of whitespace with minimal code change it's much easier to differentiate what happened.

I have reviewed this exhaustively and can confirm that it's a big file full of SQL 👀

This variation feels much better, but let me get somewhere useful with it to make sure it isn't another blind alley.

• More pure variation that does everything we need with just functions.

The complexity of handling this makes adding a "the whole repository is caught up, deal with it" from T4453#13 sort of step more attractive. This would be far easier to motivate if we had more stuff that suffered from similar issues, though.

I believe this was resolved by D20327 / D20393.

I believe this has been fixed by D20327 / D20393 -- at least, the examples above no longer seem to reproduce any bad behavior.

Also, before regenerating this I disabled all the Phacility extensions. Otherwise, we get dumps of instances/ tables and such.